Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Composable ChainExtension #11816

Merged
merged 9 commits into from
Jul 14, 2022

Conversation

athei
Copy link
Member

@athei athei commented Jul 11, 2022

@athei athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jul 11, 2022
@athei athei requested review from agryaznov and cmichi July 12, 2022 07:57
frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
frame/contracts/src/chain_extension.rs Outdated Show resolved Hide resolved
frame/contracts/src/chain_extension.rs Show resolved Hide resolved
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

frame/contracts/src/chain_extension.rs Outdated Show resolved Hide resolved
frame/contracts/src/chain_extension.rs Outdated Show resolved Hide resolved
frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
@HCastano
Copy link
Contributor

@xgreenx @Maar-io I think you guys will find this interesting

@athei
Copy link
Member Author

athei commented Jul 14, 2022

Reworked how test inputs are build to address comments of @HCastano.

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@HCastano
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 37cca71 into master Jul 14, 2022
@paritytech-processbot paritytech-processbot bot deleted the at/composeable-chain-ext branch July 14, 2022 18:14
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* Add `RegisteredChainExtension`

* Add tests

* Update frame/contracts/src/chain_extension.rs

Co-authored-by: Michael Müller <michi@parity.io>

* Add more docs

* Remove debugging leftover

* Make ChainExtension-registry lowercase

* Apply suggestions from code review

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Improve clarity of test inputs

Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Add `RegisteredChainExtension`

* Add tests

* Update frame/contracts/src/chain_extension.rs

Co-authored-by: Michael Müller <michi@parity.io>

* Add more docs

* Remove debugging leftover

* Make ChainExtension-registry lowercase

* Apply suggestions from code review

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Improve clarity of test inputs

Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

contracts: Make chain extensions composeable
3 participants