This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Properly defer slashes #11823
Merged
Properly defer slashes #11823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
github-actions
bot
added
A3-in_progress
Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com>
…te into kiz-fix-staking-slash
rphmeier
approved these changes
Jul 16, 2022
|
@shawntabrizi @ggwpez would be good if you take a look here sometime soon. |
|
bot rebase |
|
Rebased |
ggwpez
approved these changes
Jul 26, 2022
| slash_era + slash_defer_duration + 1, | ||
| ); | ||
| <Self as Store>::UnappliedSlashes::mutate( | ||
| slash_era.saturating_add(slash_defer_duration).saturating_add(One::one()), |
There was a problem hiding this comment.
Maybe pull the slash_era.saturating_add(slash_defer_duration).saturating_add(One::one()) out and use it in the log above as well?
There should also be saturating_inc.
|
bot merge |
|
This PR is assuming that there are no existing pending slashes in storage. If there are, they might become prematurely executed (or other behavior). Something to look into. |
|
aghhh shit, this would probably allow you to evade a slash, since in the old logic we write to a key in Options:
|
jakoblell
added
D1-audited 👍
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* initial draft of fixing slashing * fix test * Update frame/staking/src/tests.rs Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> * last touches * add more detail about unbonding * add migration * fmt Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> Co-authored-by: parity-processbot <>
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* initial draft of fixing slashing * fix test * Update frame/staking/src/tests.rs Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> * last touches * add more detail about unbonding * add migration * fmt Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(assuming polkadot context, where slash deferring is 27 eras and bonding duration is 28).
A slash can happen at any given era
s, and can be reported at any given erar, as long ass + 28 > r >= s. This is because we must assume that even if a slash is reported later, the offender knows about it, and they will attempt to unbond and leave the system. Therefore, we must apply the slash latest at the beginning of eras + 28, otherwise the offender may have fully unbonded, leaving the slash incomplete, and posing a fundamental risk to the economic security of the chain.The old logic would defer a slash reported at
rtor + 27, and this seems clearly wrong to me. This would easily allow an offence that is being reported with a delay to evaded entirely. Instead a slash should be deferred tos + 27, i.e. relative to when it occurred, not when it was reported.