Name the score of the election in election finalized event #12069
Conversation
kianenigma
added
A0-please_review
|
update? |
Yeah, I'm adding the tests. 😄 Pls review . |
2.Add one test that does ElectionCompute::Signed and one that does ElectionCompute::Unsigned to check 'Event::SolutionStored' and 'Event::ElectionFinalized'
There was a problem hiding this comment.
Sorry, but https://github.com/paritytech/substrate/pull/12069/files#r958430459 is still incorrect.
| election_compute: Some(ready_solution.compute), | ||
| score: Some(ready_solution.score), | ||
| }); | ||
| <QueuedSolution<T>>::take() |
There was a problem hiding this comment.
I hope you agree that this looks better.
|
@hzy1919 can you add your polkadot address for a tip? https://github.com/paritytech/substrate-tip-bot/ |
|
bot merge |
@kianenigma yeah, I have added my polkadot address. Thanks for all your help ! |
|
Hi @kianenigma , I found the tip-bot hasn't been executed yet when I collected informations for member request of polkadot-fellows-seeding. |
…h#12069) * Name the score of the election in ElectionFinalized event * fmt * 1.Adjust the logic of the function 'do_elect()'. 2.Add one test that does ElectionCompute::Signed and one that does ElectionCompute::Unsigned to check 'Event::SolutionStored' and 'Event::ElectionFinalized' * Fix from kian * fmt and update comment. Co-authored-by: kianenigma <kian@parity.io>
Fixes #12042
polkadot address: 15wPGN5vysDW1HYWfZRjQQhv2ktpfLMMuiJNMRKcodwPfM14