Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix nomination pools pending rewards RPC #12095

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Fix nomination pools pending rewards RPC #12095

merged 5 commits into from
Aug 28, 2022

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Aug 23, 2022 •
edited
Loading

Unfortunately, the RPC added in #11831 had a small bug. This fixes it.

Polkadot companion: paritytech/polkadot#5924

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C3-medium PR touches the given topic and has a medium impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Aug 23, 2022
@kianenigma kianenigma marked this pull request as ready for review August 23, 2022 21:24
@github-actions github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. A0-please_review Pull request needs code review. and removed A0-please_review Pull request needs code review. A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 23, 2022
@kianenigma kianenigma mentioned this pull request Aug 23, 2022
Merged
@kianenigma kianenigma requested a review from ggwpez August 23, 2022 21:30
@kianenigma
Copy link
Contributor Author

cc @Szegoo lesson learned the hard way, my suggestion about how to do this in the original PR was wrong, and I didn't ask for a test.

@kianenigma kianenigma added B7-runtimenoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels Aug 23, 2022
rossbulat
rossbulat approved these changes Aug 23, 2022
View reviewed changes
Copy link

@rossbulat rossbulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good, payouts are distributed proportionally to the join bond of each member at the correct stages.

None is yielded when member is not a member of the pool.

ggwpez
ggwpez approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will immediately diener build Kusama and try it 😆
I somehow dont see the new function in the results of rpc_methods...

@chevdor chevdor added this to the Polkadot v0.9.29 milestone Aug 24, 2022
@Szegoo
Copy link
Contributor

Szegoo commented Aug 24, 2022

Looks good, I will immediately diener build Kusama and try it laughing I somehow dont see the new function in the results of rpc_methods...

I believe that is because this isn't actually a custom RPC, you should be able to use state_Call RPC.

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#5924

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 4c83ee0 into master Aug 28, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-fix-pools-RPC branch August 28, 2022 12:55
@kianenigma kianenigma mentioned this pull request Sep 1, 2022
Closed
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
@hussein-aitlahcen hussein-aitlahcen mentioned this pull request Jan 16, 2023
Merged
7 tasks
vimukthi-git pushed a commit to ComposableFi/composable that referenced this pull request Jan 18, 2023
@hussein-aitlahcen @cor
[PICA-34] - Upgrade to polkadot v0.9.30 (#2913)
2ec221a 
#### Intro

Upgrade polkadot from v0.9.27 to v0.9.30 as a checkpoint, then to
v0.9.33 (latest version without workspace dependencies)

Require ComposableFi/composable-ibc#176 to be merged
first.

#### Migrations
- v0.9.28
    - [x] paritytech/polkadot#5582
        - Nomination not present in our runtimes
- v0.9.29
    - [x] paritytech/substrate#12095
        - Nomination not present in our runtimes
- v0.9.30
    - [x] paritytech/substrate#12034
        - BagList/Staking not present in our runtimes
    - [x] paritytech/polkadot#5930
        - Nomination/BagList/Staking not present in our runtimes
    - [x] paritytech/substrate#12230
        - Staking not present in our runtimes
    - [x] paritytech/polkadot#5996
        - Staking not present in our runtimes
    - [x] paritytech/substrate#12083
        - Contracts not present in our runtimes

Signed-off-by: cor <cor@pruijs.dev>
Co-authored-by: cor <cor@pruijs.dev>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@kianenigma @ark0f
Fix nomination pools pending rewards RPC (paritytech#12095)
1dcb573 
* Fix nomination pools pending rewards RPC

* Fix node

* Update frame/nomination-pools/src/lib.rs

* Fix docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@rossbulat rossbulat rossbulat approved these changes

@ggwpez ggwpez ggwpez approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
Polkadot v0.9.29
Development

Successfully merging this pull request may close these issues.
7 participants
@kianenigma @Szegoo @shawntabrizi @bkchr @ggwpez @rossbulat @chevdor