This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Replace 'blake2-rfc' with rust-crypto 'blake2' crate #12266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davxy
added
A0-please_review
michalkucharczyk
approved these changes
Sep 14, 2022
bkchr
approved these changes
Sep 14, 2022
koute
approved these changes
Sep 14, 2022
davxy
added
the
D3-trivial 🧸
Closed
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Replace 'blake2-rfc with rust-crypto 'blake2' crate * Bump blake2 to 0.10.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12260
Added a couple of tests exercising an uncovered code path wrt key derivation (where blake2 was involved)
Performances of the two libraries were found to be approximately equal
Results using Substrate startup performance tests (CPU-SCORE MB/s). Bigger Is better.
Three samples...
Results using directly criterion: https://github.com/davxy/crypto-benches/tree/main/hash#blake2
Blake2-rfc is now pulled in only by parity-db. But I think that it can be replaced there as well...
polkadot companion: paritytech/polkadot#6019