Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Undo removing migration checks #12330

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Undo removing migration checks #12330

merged 2 commits into from
Sep 24, 2022

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Sep 22, 2022 •
edited
Loading

Re add the migration pre and post checks that was removed for PR #12230.

With @ruseinov's fix for sequential execution of migrate functions #12319, we do not need to do this hack anymore.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Sep 22, 2022
@Ank4n Ank4n requested a review from ruseinov September 22, 2022 15:40
@Ank4n Ank4n marked this pull request as ready for review September 22, 2022 15:41
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Sep 22, 2022
@Ank4n Ank4n added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Sep 22, 2022
@Ank4n Ank4n changed the title Ankan/bounding staking migrate sequentially Undo removing migration checks Sep 22, 2022
@Ank4n
Copy link
Contributor Author

Ank4n commented Sep 22, 2022

/cmd queue -c fmt $ 1

@command-bot
Copy link

command-bot bot commented Sep 22, 2022 •
edited
Loading

@Ank4n https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1873093 was started for your command "$PIPELINE_SCRIPTS_DIR/fmt.sh" 1. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 42-7f6cd7a7-6e08-4aea-bd50-01db0a94212c to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 22, 2022

@Ank4n Command "$PIPELINE_SCRIPTS_DIR/fmt.sh" 1 has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1873093 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1873093/artifacts/download.

@ruseinov ruseinov self-requested a review September 23, 2022 14:51
@Ank4n Ank4n force-pushed the ankan/bounding-staking-migrate-sequentially branch from bdabdbf to 185ed2e Compare September 23, 2022 15:12
@kianenigma
Copy link
Contributor

just a minor note: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#rules

@Ank4n
Copy link
Contributor Author

Ank4n commented Sep 24, 2022

just a minor note: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#rules

Noted

@Ank4n Ank4n requested review from ggwpez and bkchr September 24, 2022 08:59
@Ank4n
Copy link
Contributor Author

Ank4n commented Sep 24, 2022

bot rebase

@paritytech-processbot
Copy link

Rebased

@Ank4n Ank4n added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Sep 24, 2022
@ggwpez ggwpez removed the D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. label Sep 24, 2022
@ggwpez ggwpez added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Sep 24, 2022
@Ank4n
Copy link
Contributor Author

Ank4n commented Sep 24, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d0214e7 into master Sep 24, 2022
@paritytech-processbot paritytech-processbot bot deleted the ankan/bounding-staking-migrate-sequentially branch September 24, 2022 19:32
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Ank4n @ark0f
re add the migration checks for staking (paritytech#12330)
652ab48 
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@kianenigma kianenigma kianenigma approved these changes

@ruseinov ruseinov ruseinov approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ank4n @kianenigma @ruseinov @ggwpez