This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Automatic withdraw_unbonded upon unbond
#12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
force-pushed
the
staking_interface-ensure_unbond
branch
from
f90291e
to
4e0e816
Compare
gpestana
changed the title
…n the staking pallet
gpestana
force-pushed
the
staking_interface-ensure_unbond
branch
from
4e0e816
to
9e569f5
Compare
gpestana
commented
Nov 8, 2022
kianenigma
reviewed
Nov 8, 2022
kianenigma
reviewed
Nov 8, 2022
kianenigma
reviewed
Nov 8, 2022
kianenigma
reviewed
Nov 8, 2022
kianenigma
reviewed
Nov 9, 2022
kianenigma
reviewed
Nov 11, 2022
…ate the consumed weight
gpestana
added
A3-in_progress
gpestana
commented
Nov 17, 2022
gpestana
commented
Nov 17, 2022
Ank4n
approved these changes
Dec 7, 2022
gpestana
added
B0-silent
kianenigma
changed the title
withdraw_unbonded upon unbond
gpestana
added
B7-runtimenoteworthy
and removed
B0-silent
|
Needs rebase. |
|
/cmd queue -c bench-bot $ pallet dev pallet_staking |
|
@gpestana https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2158490 was started for your command Comment |
|
@gpestana Command |
jakoblell
added
D1-audited 👍
|
bot merge |
paritytech-processbot
bot
deleted the
staking_interface-ensure_unbond
branch
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529/1 |
karapetyantv
added a commit
to mixbytes/lido-dot-ksm
that referenced
this pull request
Jan 9, 2023
After changes introduced in paritytech/substrate#12582 unbond method now additionaly calls withdraw_unbond_kill
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Prevents max unbonding chunk slots from being filled when unbonding in the staking pallet * hardcode num_slashing to unlock chunks automatically * refactor withdraw logic to do_withdraw; idiomatic rust improvements * a * callable unbond() to return a DispatchWithPostInfo to dynamically update the consumed weight * refunds overpaid fees when unbond with withdraw * fetches real slashing spans before withdrawal call * nits * addresses PR comments * Adds more testing * fixes doc comments * Fixes weight refunding logic for fn unbond * generalizes to return used weight or dispatch error * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Addresses PR comments * Add comment to speculative num spans * adds missing add_slashing_spans in withdraw_unbonded_kill benchmarks * ".git/.scripts/bench-bot.sh" pallet dev pallet_staking * fix publish Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: command-bot <>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Prevents max unbonding chunk slots from being filled when unbonding in the staking pallet * hardcode num_slashing to unlock chunks automatically * refactor withdraw logic to do_withdraw; idiomatic rust improvements * a * callable unbond() to return a DispatchWithPostInfo to dynamically update the consumed weight * refunds overpaid fees when unbond with withdraw * fetches real slashing spans before withdrawal call * nits * addresses PR comments * Adds more testing * fixes doc comments * Fixes weight refunding logic for fn unbond * generalizes to return used weight or dispatch error * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Addresses PR comments * Add comment to speculative num spans * adds missing add_slashing_spans in withdraw_unbonded_kill benchmarks * ".git/.scripts/bench-bot.sh" pallet dev pallet_staking * fix publish Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: command-bot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the flow of
fn unbondto try to release unbonding chunks if the slots are full. Before unbonding,fn unbondwill check if there are still chunk slots available for the controller's account. If no available chunk slots, then thefn withdrawn_unbondwill be implicitly called to free up space in the chunk queue and proceed with the unbond. The call tofn unboundmay still fail withNoMoreChunksif it was not possible to unlock free chunks due to the unbonding duration.