First iteration of Storage append #12637
Conversation
primitives/state-machine/src/ext.rs
Outdated
| self.0 = match Vec::<EncodeOpaqueValue>::append_or_new(item.data, &value) { | ||
| Ok(data) => { | ||
| let num = <u32>::from(item.num).saturating_add(1); | ||
| let num = Compact::<u32>::from(num); | ||
| let appended_value = AppendedValue{ | ||
| num, | ||
| data, | ||
| materialized: None | ||
| }; | ||
| appended_value | ||
| }, |
There was a problem hiding this comment.
The code you have added here doesn't make that much sense. You should not call append_or_new anymore. You want to move the materialization close to the point where the runtime actually calls get on this data or we want to store it in the state.
In general you should make yourself familiar with OverlayedChanges and how that works. Especially in the light of storage transaction. Currently both of these things just work with Vec<u8>s. This would need to be changed to have values either be some Vec<u8> or a AppendedValue.
The entire point of the linked issue is to improve the performance of the append operation, especially when it comes to storage transactions.
There was a problem hiding this comment.
Okey and so I need to make that if runtime request data it should first check materialized because it will contain latest data and if not it will go on checking data field.
And when storing I should first update materialized field then go on appending the data into the vec.
And on OverlayedChanges shouldn't be only working with AppendValue because inside it it will have data filed with vec<u8> ?
There was a problem hiding this comment.
And am into it will make some changes and iterate
There was a problem hiding this comment.
And on
OverlayedChangesshouldn't be only working withAppendValuebecause inside it it will have data filed withvec<u8>?
I don't get this question.
And when storing I should first update materialized field then go on appending the data into the
vec.
Materialized should be set to None when appending new data.
Okey and so I need to make that if runtime request data it should first check materialized because it will contain latest data and if not it will go on checking data field.
First check materialized and if that doesn't exist, create materialized from the data + length.
There was a problem hiding this comment.
Check the new commit, does not compile yet , But i wanted to make sure that am heading straight.
So at first OverlayedChanges only worked with vec<u8> but Ive changed to work with AppendedValue but also I will have to change numerous APIs. So while appending it increments the num field and changes the data field
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Fixex paritytech/polkadot-sdk#30,
Few questions to @bkchr
With some few clarifications i can finish this issue in no time