Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

upgrade libp2p to 0.50.0 #12734

Merged

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 18, 2022

This is needed for #12529 and #11514.

polkadot companion: paritytech/polkadot#6500
cumulus companion: paritytech/cumulus#2056

@melekes melekes added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 18, 2022
@melekes melekes self-assigned this Nov 28, 2022
@melekes melekes marked this pull request as ready for review November 28, 2022 04:39
@melekes melekes added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 28, 2022
@melekes melekes requested a review from altonen November 28, 2022 07:44
@kpp kpp mentioned this pull request Nov 29, 2022
3 tasks
@altonen altonen requested a review from bkchr November 29, 2022 07:07
@melekes
Copy link
Contributor Author

melekes commented Jan 4, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 854c749

@melekes
Copy link
Contributor Author

melekes commented Jan 4, 2023

  1. Should I open PRs for polkadot / cumulus? If so, what should I do there? Point substrate to my branch instead of master?
  2. pallet_ui tests keep failing 😞 I will try to dig the reason, but I doubt it's because of libp2p

@melekes
Copy link
Contributor Author

melekes commented Jan 4, 2023

  1. pallet_ui tests keep failing 😞 I will try to dig the reason, but I doubt it's because of libp2p

so the problem seems to be the tests runner not rendering a number, but printing an env variable instead: and $N others. Note that we expect smth like and 79 others.

@bkchr
Copy link
Member

bkchr commented Jan 4, 2023

  1. pallet_ui tests keep failing disappointed I will try to dig the reason, but I doubt it's because of libp2p

so the problem seems to be the tests runner not rendering a number, but printing an env variable instead: and $N others. Note that we expect smth like and 79 others.

The commit looks fine. Seems like there is maybe some non-deterrministic issue in rustc: rust-lang/rust#106417

Regarding restarting CI, you can also just get access to gitlab and restart it with a button click instead of pushing empty commits.

@melekes
Copy link
Contributor Author

melekes commented Jan 4, 2023

Regarding restarting CI, you can also just get access to gitlab and restart it with a button click instead of pushing empty commits.

requested access. thanks 🙏

@melekes
Copy link
Contributor Author

melekes commented Jan 5, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#6500

@melekes
Copy link
Contributor Author

melekes commented Jan 5, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#6500

@melekes
Copy link
Contributor Author

melekes commented Jan 5, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 05fe10b into paritytech:master Jan 5, 2023
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
* upgrade libp2p to 0.50.0

* on_swarm_event and on_connection_handler_event

* replace `Swarm::new` with `Swarm::with_threadpool_executor`

* on_swarm_event and on_connection_handler_event part 2

* on_swarm_event and on_connection_handler_event part 3

* on_swarm_event and on_connection_handler_event part 4

* update libp2p

* libp2p 0.50.0

* rename OutboundQueryCompleted to OutboundQueryProgressed

refs libp2p/rust-libp2p#2712

* remove unused var

* accumulate outbound_query_records until query is finished

* format code

* use p_handler instead of new_handler

paritytech#12734 (comment)

* pass ListenFailure to kademlia

paritytech#12734 (comment)

* use tokio executor in tests

paritytech#12734 (comment)

* use chrono Local::now

instead of deprecated Local::today

* remove unused vars from request_responses tests

* attempt to fix pallet UI tests

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* upgrade libp2p to 0.50.0

* on_swarm_event and on_connection_handler_event

* replace `Swarm::new` with `Swarm::with_threadpool_executor`

* on_swarm_event and on_connection_handler_event part 2

* on_swarm_event and on_connection_handler_event part 3

* on_swarm_event and on_connection_handler_event part 4

* update libp2p

* libp2p 0.50.0

* rename OutboundQueryCompleted to OutboundQueryProgressed

refs libp2p/rust-libp2p#2712

* remove unused var

* accumulate outbound_query_records until query is finished

* format code

* use p_handler instead of new_handler

paritytech#12734 (comment)

* pass ListenFailure to kademlia

paritytech#12734 (comment)

* use tokio executor in tests

paritytech#12734 (comment)

* use chrono Local::now

instead of deprecated Local::today

* remove unused vars from request_responses tests

* attempt to fix pallet UI tests

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI

* restart CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants