-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the many variant is sufficient for all cases, as you can always provide a single element Vec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reminder that we need to add the MigrateToTrackInactive
migration struct to the runtimes after this is done.
That does however bring up a question: which migration struct should each runtime use? MigrateToTrackInactive
or MigrateManyToTrackInactive
? As it is written, each runtime can only use one or the other, but not both at the same time.
Right. We will only need the first one for all chains we use, however I cannot rule out the possibility that ecosystem chains have multiple accounts which contain inactive funds so the second variant is provided. Of course the second is strictly more general, however using it would require additional verbosity since the Checking Account is always stored in a single already-exposed type param which fits neatly into the first variant and not the second. So it's provided in the interest of easing developability and reducing the chance of bugs creeping in from tedious boilerplate. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Tweak to active total migrations * Formatting * Expose trait * Remove empty pre_ and post_upgrade hooks. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Tweak to active total migrations * Formatting * Expose trait * Remove empty pre_ and post_upgrade hooks. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
One extra migration, in case there are multiple accounts with inactive funds.