Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Warn on missing pallet::call_index #12894

Merged
merged 10 commits into from
Dec 15, 2022
Merged

Warn on missing pallet::call_index #12894

merged 10 commits into from
Dec 15, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Dec 9, 2022 •
edited
Loading

Emit a warning when a pallet is not in dev mode and is still using implicit call ordering. For example assets::refund:

warning: use of deprecated struct `pallet::warnings::refund`: 
			Implicit call indices are deprecated in favour of explicit ones.
			Please ensure that all calls have the `pallet::call_index` attribute or that the
			`dev-mode` of the pallet is enabled. For more info see:
			<https://github.com/paritytech/substrate/pull/12891> and
			<https://github.com/paritytech/substrate/pull/11381>.
    --> frame/assets/src/lib.rs:1452:10
     |
1452 |         pub fn refund(
     |                ^^^^^^

Depends on #12891 since the CI forbids warnings.

TODO:

  • Pallet UI tests

@ggwpez
Warn on missing call_index
0601b49 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 9, 2022
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Dec 9, 2022
@ggwpez
Suppress camel case warning
d6ac74f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Dec 12, 2022
Merged
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-warn-missing-ca…
a6f6f72 
…ll-index
@ggwpez
Simplify code
5e206d8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Disallow warnings in pallet-ui tests
a00adb3 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add pallet UI test
a26ff78 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Pallet UI
92b1dd7 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
fmt
d2c4ab5 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 12, 2022
@ggwpez ggwpez requested a review from sam0x17 December 12, 2022 22:42
@sam0x17
Copy link
Contributor

sam0x17 commented Dec 14, 2022

Neat trick for issuing a warning btw! Can't wait until they stabilize issuing warnings at compile-time..

sam0x17
sam0x17 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ggwpez ggwpez requested a review from KiChjang December 14, 2022 16:04
@ggwpez
Use module instead of function
ffa1066 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update pallet-ui
5f4bbe2 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Dec 15, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit cb4f249 into master Dec 15, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-warn-missing-call-index branch December 15, 2022 10:38
@nazar-pc nazar-pc mentioned this pull request Dec 15, 2022
Merged
1 task
@ggwpez ggwpez mentioned this pull request Dec 16, 2022
Merged
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529/1

@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
@librelois librelois mentioned this pull request Jan 23, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@ggwpez @ltfschoen
Warn on missing pallet::call_index (paritytech#12894)
5abe210 
* Warn on missing call_index

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Suppress camel case warning

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Simplify code

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Disallow warnings in pallet-ui tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add pallet UI test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Pallet UI

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use module instead of function

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update pallet-ui

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ggwpez @ark0f
Warn on missing pallet::call_index (paritytech#12894)
3bb89b0 
* Warn on missing call_index

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Suppress camel case warning

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Simplify code

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Disallow warnings in pallet-ui tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add pallet UI test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Pallet UI

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use module instead of function

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update pallet-ui

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Apr 24, 2023
Open
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @sam0x17 @Polkadot-Forum @KiChjang