This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[NFTs] Track item's metadata depositor #13124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidorenko
added
B0-silent
joepetrowski
approved these changes
Jan 11, 2023
gilescope
approved these changes
Jan 11, 2023
|
bot merge |
|
This PR cannot be merged at the moment due to: 3 of 13 required status checks are expected. processbot expects that the problem will be solved automatically later and so the auto-merge process will be started. You can simply wait for now. |
jsidorenko
added
A0-please_review
|
Merge cancelled due to error. Error: Checks failed for e39130b |
gilescope
approved these changes
Jan 11, 2023
|
bot merge |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Refactor do_mint() * Track the depositor of item's metadata * Revert back the access control * On collection destroy return the metadata deposit * Clear the metadata on item burn returning the deposit * Address comments * Fix clippy * Don't return Ok on non-existing attribute removal
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122/1 |
This was referenced Feb 22, 2023
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Refactor do_mint() * Track the depositor of item's metadata * Revert back the access control * On collection destroy return the metadata deposit * Clear the metadata on item burn returning the deposit * Address comments * Fix clippy * Don't return Ok on non-existing attribute removal
6 tasks
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upcoming feature to support the pre-signed claims those would allow to offload of the deposit onto the final NFT's receiver, we need to start tracking the metadata depositor in a similar way as we did for attributes.