This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: cleanup stale entries in set id session mapping #13237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
added a commit
to paritytech/polkadot
that referenced
this pull request
Jan 24, 2023
|
Regarding the migration here are the current set ids of all networks: So the migration should run fine. |
bkchr
approved these changes
Jan 24, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
andresilva
force-pushed
the
andre/grandpa-cleanup-stale-set-id-session
branch
from
b32203e
to
50b175d
Compare
melekes
reviewed
Jan 25, 2023
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
davxy
reviewed
Jan 26, 2023
Comment on lines
+38
to
+42
| // NOTE: since this migration will loop over all stale entries in the | ||
| // map we need to set some cutoff value, otherwise the migration might | ||
| // take too long to run. for scenarios where there are that many entries | ||
| // to cleanup a multiblock migration will be needed instead. | ||
| if CurrentSetId::<T>::get() > 25_000 { |
There was a problem hiding this comment.
Just curious.
In case we have more than X entries this will bail out entirely.
In this case what is the strategy to cleanup the leftovers?
The note talks about a multi-block migration. How this can be implemented? And who is in charge to implement it? Just asking to prevent it from being forgotten forever 😃
Also at this point can't we at least use a best effort approach and cleanup the first X entries?
Another idea/question (not a super expert of runtime upgrades... but I assume it can work)
If we save in the state a temporary variable to keep track of where we arrived (with the cleanup) so far and we leave this migration code here for the next runtime, then in the worst case after a bunch of upgrades we cleaned everything and at that point we also remove the temporary state variable.
There was a problem hiding this comment.
I just put this (random) cut-off here to prevent any users from shooting themselves in the foot. By "multi-block" migration I mean exactly what you suggested, just keep track of the current state of cleanup and remove N entries every block until it's finished. The reason I didn't implement this is because we don't need it for any of our networks and I figured it was unnecessary to add the extra complexity. I put this note here in case any other user of substrate needs to implement this (TBH even 25000 entries might be fast enough to do in a single block, I didn't test this as our limits are way lower than this ~6500).
davxy
approved these changes
Jan 30, 2023
|
bot merge |
|
Error: Github API says paritytech/polkadot#6626 is not mergeable |
|
bot merge |
paritytech-processbot
bot
deleted the
andre/grandpa-cleanup-stale-set-id-session
branch
paritytech-processbot bot
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Jan 30, 2023
* companion for paritytech/substrate#13237 * test-runtime: add MaxSetIdSessionEntries * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
rossbulat
pushed a commit
that referenced
this pull request
Feb 3, 2023
* grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
Ank4n
pushed a commit
that referenced
this pull request
Feb 5, 2023
* grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…13237) * grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
This was referenced Feb 22, 2023
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…13237) * grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
Ank4n
pushed a commit
that referenced
this pull request
Feb 28, 2023
* grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Mar 10, 2023
* companion for paritytech/substrate#13237 * test-runtime: add MaxSetIdSessionEntries * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
6 tasks
13 tasks
devdanco
added a commit
to gasp-xyz/substrate
that referenced
this pull request
May 25, 2023
* Use the balance trait as we have one (#13136)
* CI: Code mark to request a pipeline failure (#13139)
* Annotate thiserror for sp_core::crypto::SecretStringError (#13144)
* pallet-offences-benchmarking: Box events in verify (#13151)
* pallet-offences-benchmarking: Box events in verify
Events in frame are represented by an enum in the pallet and the runtime. The size of an enum in
Rust depends on the size of biggest variant. This means we always need to allocate memory for the
biggest variant when allocating memory for an event. The offences benchmarking is verifying the
benchmarking results by checking the events. To check the events it is generating all the expected
events. With the recent changes in Polkadot the events are too big and lead to issues when running
this verify functions. The solution is to box each event, as the vector holding all the events will
then only need to hold fat pointers * expected events, instead of size_of(event) * expected events.
This issue isn't a problem in production, as we never read the events on chain. When we are reading
the events, it is done in an offchain context and they are only decoded one by one.
Besides that this also enables the benchmarking verification for everyone running these benchmarks.
* FMT
* Disable checking again
* More improvements for the crate publishing pipeline (#13153)
* more improvements for the crate publishing pipeline
* move default definitions to the publish-crates script
* add script to check the crate publishing pipeline at the start
* fix yaml references
* move more variables to .crates-publishing-pipeline
* separate .crates-publishing-pipeline from .crates-publishing-variables
* clean up redundant and unused code
* txpool: don't maintain the pool during major sync (#13004)
* txpool: don't maintain the pool during major sync
Fix shall prevent from wasting the CPU during the major sync. No actions
are actually required in transaction pool during the major sync.
Fixes: #12903
* passing sync_oracle to maintain method
* fixed: builder, txpool tests
* do not maintain tx-pool if node gone out of sync
* EnactmentAction: all logic moved to EnactmentState
Tests to be done.
* maintain guard logic moved directly to MaintainedTransactionPool
* minor fixes
* EnactmentAction: all logic moved to EnactmentState (again)
* SyncOracle fixes here and there
* Update client/transaction-pool/src/enactment_state.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/transaction-pool/src/enactment_state.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* sync_oracle removed
* spelling + fmt + doc
* Review suggestions applied
* log::info -> debug
* Update client/transaction-pool/src/enactment_state.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* ".git/.scripts/commands/fmt/fmt.sh"
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
* [client/network] Add support for `/wss` addresses (#13152)
* join dns with another instance of WS transport
Secure Websocket transport needs unresolved addresses, so we join DNS transport with
yet another instance of Websocket transport.
Closes #12024
* WSS transport itself need to wrap DNS transport
in order to resolve addresses before passing them down to TCP transport
Refs https://github.com/libp2p/rust-libp2p/issues/3330
* reverse order
* simplify code: remove WS from WSS inner DNS transport
* remove the 2nd instance of WS transport
* NIS should retain funds in reserve (#12928)
* Keep funds with receipt holder
* Counterpart is optional
* Use named reserves
* Tests
* Benchmarks
* Fixes
* Update frame/nis/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update frame/nis/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update frame/nis/src/lib.rs
* Update frame/nis/src/lib.rs
* Update frame/nis/src/tests.rs
* Update frame/nis/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update frame/nis/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update frame/nis/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update frame/nis/src/lib.rs
* Update frame/nis/src/lib.rs
* Update frame/nis/src/lib.rs
* Update frame/nis/src/lib.rs
* Formatting
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Refactory of `next_slot` method (#13155)
Refactory of `next_slot` method
* Prevents slot worker exit if inherent data provider creation fails
* Failure is not possible anymore
* Fix potential failure after warp-sync where block headers of not already downloaded blocks are used by the inherent data provider
* Breakout mock runtimes to separate files (#13150)
* break out moch runtimes to separate files
* tranaction-payment: break out tests & mock runtime to separate files
* frame-benchmarking: Macros should not force a particular env (#13161)
The macros in frame-benchmarking relied on having all the macros imported, which isn't a behavior
for a proper macro :D This pr fixes this by making all internal macro usages absolute.
* Fix the `storage_size`/`state_getStorageSize` RPC call (#13154)
* Have `KeyIterator` clone the `prefix` it receives
* Stream keys in `storage_size` RPC and add a runtime limit
* Update client/rpc/Cargo.toml
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/rpc/src/state/utils.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Rename the types to signify that the cancellation is due to a timeout
* Move the test into a `mod tests`
* Add a comment regarding `biased` in `tokio::select`
* Make the `clone` explicit when calling `KeyIterator::{new, new_child}`
Co-authored-by: Bastian Köcher <git@kchr.de>
* [contracts] Adapt storage reading host functions to Weights V2 (#12976)
* update RuntimeCosts to Weights V2, update tests
* improve docs
* clearer naming and docs to compat_weight helper
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
* save before master merge
* HostFnWeights to Weight
* added to_weight! macro
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
* RuntimeCosts::ChainExtension to weight_v2
* chain extension to weight v2
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
* zobmienet tests are not supposed to fail (#13015)
* zobmienet tests are not supposed to fail
* Update scripts/ci/gitlab/pipeline/zombienet.yml
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
* [contracts] Add integrity checks by pallet hook (#12993)
* integrity test for MaxCodeLen and CallStack::len()
* integrity test for MaxDebugBufferLen
* addressed review comments
* fix append_debug_buffer()
* ci fix
* updated code_len_limit formula after further discussion
* enlarged mem safe margin after discussion
* +doc to Config trait associated types
* Apply suggestions from code review
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
* more lil fixes from code review feedback
* lowered max call depth to satisfy mem limits
* fix node runtime pallet params to satisfy integrity check
* fix max call depth value calc
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
* Expose `UnknownBlock` error via `ApiError` (#12707)
* Expose `UnknownBlock` error via `ApiError`
In [certain cases](https://github.com/paritytech/polkadot/issues/5885) a
runtime api is called for an unknown block. For example a block which is
already pruned or on an abandon fork.
In such cases the correct error is returned but it is wrapped in
`ApiError::Application` and the only way to figure out what is the
problem is to inspect the actual message in the error. In polkadot for
example this usually happens when the runtime api version is being
queried. It's beneficial to be able to clearly separate such errors so i
that when they occur the client side can handle them more gracefully.
E.g. log less stressful error message than `State already discarded for
BlockId` or cancel any pending work related on this block.
* Update primitives/api/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
* Notification-based block pinning (#13157)
* Worker
* Reorganize and unpin onnotification drop
* Pin in state-db, pass block number
* Pin blocks in blockchain db
* Switch to reference counted LRU
* Disable pinning when we keep all blocks
* Fix pinning hint for state-db
* Remove pinning from backend layer
* Improve readability
* Add justifications to test
* Fix justification behaviour
* Remove debug prints
* Convert channels to tracing_unbounded
* Add comments to the test
* Documentation and Cleanup
* Move task start to client
* Simplify cache
* Improve test, remove unwanted log
* Add tracing logs, remove expect for block number
* Cleanup
* Add conversion method for unpin handle to Finalitynotification
* Revert unwanted changes
* Improve naming
* Make clippy happy
* Fix docs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
* Use `NumberFor` instead of u64 in API
* Hand over weak reference to unpin worker task
* Unwanted
* &Hash -> Hash
* Remove number from interface, rename `_unpin_handle`, LOG_TARGET
* Move RwLock one layer up
* Apply code style suggestions
* Improve comments
* Replace lru crate by schnellru
* Only insert values for pinned items + better docs
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* Improve comments, log target and test
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
* Make DispatchError impl MEL (#13169)
* Make DispatchError impl MEL
* Upgrade SCALE codec to support `codec(skip)` for MEL
Co-authored-by: Bastian Köcher <info@kchr.de>
* Remove fixtures from crate (#13181)
* txpool: LOG_TARGET const added (#13180)
* txpool: LOG_TARGET const added
part of: #12873
* LOG_TARGET added to tests mod
* txpool::api for api
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* ".git/.scripts/commands/fmt/fmt.sh"
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
* Fix potential huge allocation as a result of `validate_block` output (#13183)
* Fix potential huge allocation as a result of `validate_block` output
* Address review comments; add more tests
* Update client/executor/wasmtime/src/runtime.rs
* Remove unnecessary comments
Co-authored-by: Bastian Köcher <git@kchr.de>
* sc-network: Ensure private addresses are disabled if requested (#13185)
When running with `--no-private-ipv4` the node should not trying to connect to any private ip
addresses. With the switch to libp2p this behavior was broken. Part of this version upgrade was the
following pr: https://github.com/libp2p/rust-libp2p/pull/2995. This pr changed the default cache
size of `libp2p-identity` from `0` aka disabled to `100`. Together with our implementation that was
calling into `identity` to request addresses for a given peer. Before the switch to libp2p 0.50.0
this was returning zero addresses, but now with the cache enabled it started to return addresses.
This pr fixes this by only letting discovery return addresses for a peer. It also ensures that we
filter private addresses if requested. The cache is also disabled to restore the previous caching
behavior, but it will actually not be called anymore.
* Warn validators with slow hardware (#12620)
* move Metric
* run hardware bench if validiator flag is being used
* fix rustdoc & update node-template
* fix
* unused improt
* warn
* move Requirement
* bench_result
* ensure_requirements
* make the code compile
* check if authority
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* nit fixes
* warning signs
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use year 2023 in the License headers (#13193)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Move slow hardware warning print logic to CLI (#13198)
* Move slow hardware warning print logic to CLI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update client/sysinfo/src/sysinfo.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
* Fix flaky BABE test (#13199)
The `authoring_blocks` test of BABE was calculating the slot based on the timestamp it sometimes
failed in CI. The problem is that we combine all the notifications and authoring futures in one big
future. This one big future may first polls one authoring future to build a block. Then it polls all
notification futures again to import the block. Then some other authoring future is polled and
builds on the imported block using the same slot and making the import fail. The solution is that we
just artificially increase the slot to make the test work.
* Add debug info in assert_has_event and assert_last_event (#12979)
* improve debug info in assert_has_event and assert_last_event
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
* new proc-macro-based benchmarking syntax (#12924)
* add stub for new benchmark macro
* benchmark syntax
* add #[extrinsic call] separator
* parse #[benchmark] item as a function
* proper emission of error when #[extrinsic_call] annotation is missing
* clean up
* enclosing module via benchmarks! { } working
* use an attribute macro on the module instead of benchmarks! { }
* cargo fmt
* working component implementation
* WIP
* working
* add syntax for Linear<A, B>
* parsing of param ranges (still need to build tuple though)
* params parsing WIP
* clean up (don't need extrinsic call name)
* use proper Result syntax for BenchmarkDef parsing
* proper parsing of Linear<0, 1> style args
* successfully parse and make use of linear component ranges :boom:
* rename support variable => home because eventually will be moved
* compile-time check that param range types implement ParamRange
* switch to using balances as example, failing on instance pallet
* successfully set up __origin and __call with balances :boom:
* clean up
* use a module
* don't need a variable for transfer
* rename benchmark_transfer -> transfer because no longer conflicts
* clean up
* working with transfer_increasing_users as well :boom:
* re-add BareBlock
* add comments for undocumented structs+functions+traits
* refactor in preparation for removing module requirements
* switch to a block instead of a module
* use the outer macro pattern to to enable #[benchmarks] aggregation
* successfully generate SelectedBenchmark :boom:
* implement components for SelectedBenchmark
* implement instance for SelectedBenchmark
* properly track #[extra]
* working impl for fn benchmarks()
* run_benchmarks WIP
* finish run_benchmark! impl :boom:
* import balances transfer_best_case benchmark
* import transfer_keep_alive balances pallet benchmark
* import set_balance_creating balances pallet benchmark
* import set_balance_killing balances pallet benchmark
* import force_transfer balances pallet benchmark
* add #[extra] annotation and docs to transfer_increasing_users
* import transfer_all balances pallet benchmark
* import force_unreserve balances pallet benchmark
* prepare to implement impl_benchmark_test_suite!
* ensure tests cover #[extra] before and after #[benchmark] tag
* refactor
* clean up
* fix
* move to outer
* switch to benchmarks/instance_benchmarks
* test impl almost done, strange compiler error
* benchmark test suites working :boom:
* clean up
* add stub and basic parsing for where_clause
* working except where clause and extrinsic calls containing method chains
* assume option (2) for now wrt https://github.com/paritytech/substrate/pull/12924#issuecomment-1372938718
* clean up
* switch to attribute-style
* properly handle where clauses
* fix subtle missing where clause, now just MessageQueue issues
* fix block formatting in message-queue pallet
* switch to block vs non-block parsing of extrinsic call
* working now but some benchmark tests failing
* message-queue tests working (run order issue fixed) :tada:
* add comments and internal docs for fame_support_procedural::benchmark
* fix license years
* docs for lib.rs
* add docs to new support procedural macros
* don't allow #[benchmark] outside of benchmarking module
* add docs
* use benchmark(extra, skip_meta) style args
* update docs accordingly
* appease clippy
* bump ci
* add notes about `extra` and `skip_meta`
* fix doc tests
* re-run CI
* use `ignore` instead of `no_run` on doc examples
* bump CI
* replace some if-lets with if-elses
* more refactoring of if-let statements
* fix remaining if-lets in BenchmarkDef::from()
* fix if-lets in benchmarks()
* fix remaining if-lets, use nested find_map for extrinsic call
* switch to use #[extrinsic_call] or #[block] situationally
* refactor ExtrinsicCallDef => BenchmarkCallDef
* update docs with info about #[block]
* add macro stub for #[extrinsic_call]
* fix docs and add stub for #[block] as well
* remove unused extern crate line
* fix clippy nits
* Use V2 bench syntax in pallet-example-basic
Just testing the dev-ex...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* carry over comment
* use curly-brace style for impl_benchmark_test_suite!
* remove unneeded parenthesis
* proper handling of _() extrinsic call style
* add docs for _() syntax
* fix crate access
* simplify keyword access
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* simplify module content destructuring
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* fix crate access "frame_benchmarking" => "frame-benchmarking", compiles
* use _() extrinsic call syntax where possible in balances
* simplify attr.path.segments.last()
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* fix compile error being suppressed
* simplify extrinsic call keyword parsing
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* use ? operator instead of return None
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* rename generics => type_use_generics
rename full_generics => type_impl_generics
* simplify extrinsic call extraction with transpose
* bump CI
* nit
* proper handling of too many + too few block/extrinsic call annotations
* change to B >= A
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* remove unneeded ignore
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* remove another ignore
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* add ui tests
* use _() style extrinsic call on accumulate_dummy
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* add range check to ParamRange
* ui test for bad param ranges
* fix failing example
* add ignore back to other failing example
* tweak expr_call span
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* fix typo
* eliminate a match
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* change pub fn benchmarks to return Result<TokenStream>
* fix origin error span
* more informative error for invalid benchmark parameter name
* fix spans on a few benchmark errors
* remove unneeded clone
* refactor inner loop of benchmark function parsing
* preserve mod attributes
* refactor outer loop of benchmark def parsing code, greatly simplified
* simplify to use a ? operator when parsing benchmark attr path
* fix another ? operator
* further simplify benchmark function attr parsing with more ? ops
* refactor extrinsic call handling to use if let rather than match
* replace is_ok => is_err
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* re-use name during expansion of benchmark def
* remove unneeded clone
* fix span for origin missing error
* fix missing semi
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: parity-processbot <>
* Rename `*-private-ipv4` to `*-private-ip` CLI args (#13208)
* Rename `*-private-ipv4` to `*-private-ip` CLI args
Renames the `*-private-ipv4` to `*-private-ip` in the CLI interface. The old names are staying as
alias, thus it will not break for anyone. Besides that it also fixes the naming in the rest of the code.
* FMT
* Remove dead code (#13213)
* [Fix] CountedMap::set now takes Counter into account (#13214)
* [Fix] CountedMap::set now takes Counter into account
* introduce tests for StorageMap
* debug assert events at genesis (#13217)
* BlockId removal: refactor: CallExecutor trait (#13173)
* BlockId removal: refactor: CallExecutor trait
It changes the arguments of CallExecutor methods:
- `call`, 'contextual_call', 'runtime_version', 'prove_execution'
from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* ".git/.scripts/commands/fmt/fmt.sh"
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
* service: storage monitor added (#13082)
* service: storage monitor added
Storage monitor added. It uses `notify` create to get notifications
about any changes to monitored path (which is database path).
Notifications are consumed in essential task which terminates when
available storage space drops below given threshold.
Closes: #12399
* Cargo.lock updated
* misspell
* fs events throttling added
* minor updates
* filter out non mutating events
* misspell
* ".git/.scripts/commands/fmt/fmt.sh"
* Update client/service/src/storage_monitor.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* storage-monitor crate added
* cleanup: configuration + service builder
* storage_monitor in custom service (wip)
* copy-paste bad desc fixed
* notify removed
* storage_monitor added to node
* fix for clippy
* publish = false
* Update bin/node/cli/src/command.rs
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* crate name: storage-monitor -> sc-storage-monitor
* error handling improved
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* publish=false removed
Co-authored-by: command-bot <>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Bastian Köcher <git@kchr.de>
* beefy: Add LOG_TARGET constant (#13222)
* LOG_TARGET const
* fmt
* Upgrade wasm-opt to 0.111.0 (#13038)
* storage-monitor: statvfs arithmetic bug fixed (#13234)
* Bump parity-db (#13226)
* pallet-assets: Rename `total_supply` to `amount` (#13229)
* pallet-assets: Rename `total_supply` to `amount`
We are actually passing the `amount` on assets being minted and not the total supply.
Closes: https://github.com/paritytech/substrate/issues/13210
* ".git/.scripts/commands/fmt/fmt.sh"
* Fix compilation
* FMT
Co-authored-by: command-bot <>
* Babe: bad epoch index with skipped epochs and warp sync (#13135)
* Detect and correct epoch-index for skipped epochs
* Code refactory
* Epoch index should be also be fixed for secondary claims with VRF
* Fix typo
* Make clippy happy
* Fix typo
* Trigger pipeline
* contracts: Deprecate random interface (#13204)
* Deprecate random interface
* Revert change to runtime file
* Fix docs
* Fix tests
* Rename to not_deprecated
* Apply suggestions from code review
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>
* Deprecate `set_rent_allowance`
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>
* [contracts] Add upfront weight of merkle trie proofs for storage reading functions (#13236)
* Add upfront weight of merkle trie proofs for storage reading functions
* drive-by fixes
* CI: Rewrite `check-each-crate` in python (#13238)
* CI: Rewrite `check-each-crate` in python
This is a much better readable version of the script and it should also work on Macos and not
siltently fail ;)
* Fix dumb bugs and print everything to stderr
* Don't buffer Python output
* :facepalm:
* :facepalm: :facepalm:
* Use check all until we have more macos runners
* Update scripts/ci/gitlab/check-each-crate.py
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update scripts/ci/gitlab/pipeline/test.yml
Co-authored-by: Vladimir Istyufeev <vladimir@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix try-runtime with create-snapshot (#13223)
* Fix try-runtime with create-snapshot
* Apply review suggestions
* reduce exec time of fast-unstake benchmarks (#13120)
* reduce exec time of fast-unstake benchmarks
* fix test
* fmt
* fix patch the tests
* fix patch the tests
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* add batch size as well
* update some benches to be better
* fix one last test
* fix
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* reduce time even more
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* fix tests
* nit
* remove
* improve the weight calc further
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* fix benchmarks
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* update
* fix
* fix
* fmt
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* lots of changes again...
* smaller input
* update
* fmt
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* cleanup
* small simplification
* fmt
* reduce exec time a bit
* fix
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* test
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* increase again
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
* review comments
* fmt
* fix
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
Co-authored-by: command-bot <>
* Rework the trie cache (#12982)
* Rework the trie cache
* Align `state-machine` tests
* Bump `schnellru` to 0.1.1
* Fix off-by-one
* Align to review comments
* Bump `ahash` to 0.8.2
* Bump `schnellru` to 0.2.0
* Bump `schnellru` to 0.2.1
* Remove unnecessary bound
* Remove unnecessary loop when calculating maximum memory usage
* Remove unnecessary `mut`s
* Add task type label to metrics (#13240)
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* upgrade nix to 0.26.1 (#13230)
* Add WeightToFee and LengthToFee impls to transaction-payment Runtime API (#13110)
* Add WeightToFee and LengthToFee impls to RPC
* Remove RPC additions
* Update frame/transaction-payment/rpc/runtime-api/src/lib.rs
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
* Add comments to length_to_fee and weight_to_fee
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Correct arithmetical semantic of `PerDispatchClass` (#13194)
* Fix PerDispatchClass arithmetic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Test PerDispatchClass arithmetic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add helpers for Weight
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Remove stale doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Dont mention Polkadot in Substrate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Remove saturating_ prefix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix usage
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Aura: Fix warp syncing (#13221)
* Aura: Fix warp syncing
We need to set the fork choice rule! When using Cumulus this is done by the `ParachainsBlockImport`,
but for standalone chains we still need this!
Closes: https://github.com/paritytech/substrate/issues/13220
* Improve fork choice
* Add Proof Size to Weight Output (#11637)
* initial impl
* add template test
* linear fit proof size
* always record proof when tracking storage
* calculate worst case pov
* remove duplicate worst case
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* more comment output
* add cli for worst case map size
* update name
* clap does not support underscores
* rename
* expose worst case map values
* improve some comments
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* update template
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* fix fmt
* more fmt
* more fmt
* Dont panic when there is no proof
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix test features
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Whitelist :extrinsic_index
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use whitelist when recording proof
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add logs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add PoV testing pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Deploy PoV testing pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Storage benches reside in the PoV pallet
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Linear regress PoV per component
Splits the PoV calculation into "measured" and "estimated".
The measured part is reported by the Proof recorder and linear
regressed over all components at once.
The estimated part is calculated as worst-case by using the max
PoV size per storage access and calculating one linear regress per
component. This gives each component a (possibly) independent PoV.
For now the measured size will always be lower than the PoV on
Polkadot since it is measured on an empty snapshot. The measured
part is therefor only used as diagnostic for debugging.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Put PoV into the weight templates
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Extra alanysis choise for PoV
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add+Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Make benches faster
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use same template comments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* ".git/.scripts/bench-bot.sh" pallet dev pallet_balances
* ".git/.scripts/bench-bot.sh" pallet dev pallet_democracy
* Update referenda mock BlockWeights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Take measured value size into account
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* ".git/.scripts/bench-bot.sh" pallet dev pallet_scheduler
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* proof_size: None
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* ugly, but works
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* wup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add pov_mode attribute to the benchmarks! macro
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use pov_mode attribute in PoV benchmarking
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Scheduler, Whitelist: Add pov_mode attr
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update PoV weights
* Add CLI arg: default-pov-mode
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Revert "Update PoV weights"
This reverts commit 2f3ac2387396470b118122a6ff8fa4ee12216f4b.
* Revert "WIP"
This reverts commit c34b538cd2bc45da4544e887180184e30957904a.
* Revert first approach
This reverts commit range 8ddaa2fffe5930f225a30bee314d0b7c94c344dd^..4c84f8748e5395852a9e0e25b0404953fee1a59e
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add extra benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_alliance
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_whitelist
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_scheduler
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Clippy 🤦
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add reference benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix doc comments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Undo logging
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add 'Ignored' pov_mode
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Allow multiple attributes per benchmark
Turns out that the current benchmarking syntax does not support
multiple attributes per bench 🤦. Changing it to support that
since otherwise the `pov_mode` would conflict with the others.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Validate pov_mode syntax
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Ignore PoV for all contract benchmarks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump macro recursion limit
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update contract weights
They dont have a PoV component anymore.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix test ffs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* pov_mode is unsupported in V2 syntax
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix pallet ui tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update pallet ui
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix pallet ui tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Parity Bot <admin@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Your Name <you@example.com>
* Use non-binary pronouns in comments. (#13209)
* use non binary pronouns in comments
* cargo fmt
* fix the use of "it" with "they" when dealing about an opperations identity
* migrate new benchmarking syntax from `frame_support::benchmarking` to `frame_benchmarking::v2` (#13235)
* * re-export frame_support::benchmarking in frame_benchmarking::
* prefer use frame_benchmarking::*; in examples, etc
* switch to frame_benchmarking::v2
* completely migrate new benchmarking code out of frame_support
* fix doc links
* remove unneeded return
Co-authored-by: Bastian Köcher <git@kchr.de>
* remove another unneeded return
Co-authored-by: Bastian Köcher <git@kchr.de>
* properly export all macros in v1
* refactor existing frame_benchmarking imports to use ::v1
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
* mutate_exists for StorageValue with ValueQuery (#13245)
* mutate_exists for StorageValue with ValueQuery
Signed-off-by: muraca <mmuraca247@gmail.com>
* added `#[crate::storage_alias]` to tests
Signed-off-by: muraca <mmuraca247@gmail.com>
* added StorageEntryMetadata
Signed-off-by: muraca <mmuraca247@gmail.com>
* Update frame/support/src/lib.rs
---------
Signed-off-by: muraca <mmuraca247@gmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix derive PassByInner with generics (#13247)
* Fix derive PassByInner with generics
* Update primitives/runtime-interface/proc-macro/src/pass_by/inner.rs
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
* docs: Fix broken documentation links for pallets (#13241)
Fixes broken links to `Config` and `Call`, for READMEs the link has
been fixed by adding the missing "/pallet" path, and for rust docs we
let the compiler figure out the type's link by itself
Signed-off-by: Jonathas-Conceicao <jonathasaoc@gmail.com>
* sc-finality-grandpa: Warp proof generation can not expect justifications (#13249)
When a node is running with `--blocks-pruning` it will also prunes justifications. So, the warp
proof generation can not use `expect` for unwrapping the justification.
* update criterion to v0.4.0 (#13142)
* fix up template (#13205)
* Remove `uncles` related code (#13216)
The code was added without any clear usage. The inherent for example is not benchmarked and not used.
* Implement RIType traits for u8 array with an arbitrary size (#13256)
* grandpa: cleanup stale entries in set id session mapping (#13237)
* grandpa: cleanup stale entries in set id session mapping
* Update frame/grandpa/src/migrations.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* grandpa: remove unused import
* grandpa: migration off-by-one
* Update frame/grandpa/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* Update frame/grandpa/src/lib.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* grandpa: MaxSetIdSessionEntries as u64
* node-template: fix MaxSetIdSessionEntries type
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* Benchmark's successful origin api update (#13146)
* try successful origin unimplemented by default
* error as a default impl for try_successful_origin
* remove successful_origin func of EnsureOrigin trait
* default impl -> unimplemented!()
* update EnsureOriginWithArg
* fix EnsureOriginWithArg
* prefix unused arg with underscore
* use try_successful_origin instead successful_origin, map err to Weightless
* fix tests
* remove default impl
* unwrap for indirect origin dep
* replace unwrap by expect with a message
---------
Co-authored-by: parity-processbot <>
* hooks default impl missing where clause (#13264)
* hooks default impl missing where clause
* add tests
* Update frame/support/test/tests/pallet_ui/pass/where_clause_missing_hooks.rs
---------
Co-authored-by: parity-processbot <>
* implemented `contains_prefix` for StorageDoubleMap and StorageNMap (#13232)
* implemented `contains_prefix` for StorageDoubleMap and StorageNMap
Signed-off-by: muraca <mmuraca247@gmail.com>
* match prefix to next_key
Signed-off-by: muraca <mmuraca247@gmail.com>
* warning unexpected behaviour with empty keys
Signed-off-by: muraca <mmuraca247@gmail.com>
* clarifications for unhashed::contains_prefixed_key
Signed-off-by: muraca <mmuraca247@gmail.com>
* added tests for StorageNMap
Signed-off-by: muraca <mmuraca247@gmail.com>
---------
Signed-off-by: muraca <mmuraca247@gmail.com>
* Calling proxy doesn't remove announcement (#13267)
* Calling proxy doesn't remove announcement
* Update frame/proxy/src/tests.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* fmt
---------
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Fee and tip represented as asset ID inside `AssetTxFeePaid` (#13083)
* fee & tip in the asset ID Balance type
* docs
* rewrite
* update runtime config
* docs
* Move beefy-merkle-tree to utils/binary-merkle-tree and make it generic (#13076)
* move BeefyMmrApi to pallet-beefy-mmr
* fix test_utils use pallet-beefy-mmr BeefyMmrApi
* Move beefy-merkle-tree to utils and Rename to Merkle-tree
* fix fmt and test
* Update merkle-tree to binary-merkle-tree and Remove Keccak256 mod from merkle-tree
* change merkle-tree name to binary-merkle-tree
* mirr fix
* Metadata V15: Derive `TypeInfo` for describing runtime types (#13272)
* scale_info: Derive TypeInfo for types present in runtime API
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* cargo: Update Cargo.lock
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
---------
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* benchmarks: EnsureRankedMember must add ranked members (#13297)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Minor: Update output validity tests (#13190)
* Minor: Update output validity tests
Quick follow-up to https://github.com/paritytech/substrate/pull/13183.
Mainly, I wanted to double check that the `test_return_max_memory_offset` test doesn't pass just
because the output length is 0.
I also:
- Organized these tests into a module.
- Added a comment explaining why we don't use the `wasm_export_functions` macro.
* Update test based on review comment
* BEEFY: define on-chain beefy-genesis and use it to coordinate voter initialization (#13215)
* beefy: add support to configure BEEFY genesis
* client/beefy: more flexible test runtime api
* client/beefy: add tests for custom BEEFY genesis
* client/beefy: ignore old state that didn't account for pallet genesis
* client/beefy: fix clippy
* frame/beefy: default BEEFY-genesis is block One::one()
* frame/beefy: add extra doc comments
---------
Co-authored-by: parity-processbot <>
* feat: add event SkepticsChosen event in society (#13291)
* feat: add event SkepticsChosen event in society
* feat: add test for SkepticsChosen event
* feat(client): significantly increase wasm instance limits (#13298)
Following https://github.com/paritytech/substrate/issues/11949, this PR will allow parachains with runtimes bigger than Kusama to use the pooling strategy.
* Remove in-tree bounded types and use bounded-collections crate (#13243)
* Remove in-tree bounded types and use bounded-collections crate
* Fixes
* Bump bounded-collections version
* cargo fmt
* Bump bounded-collections
* Only export non-bounded types at the top level
* Fixes
* Bump bounded-collections
* update linregress in frame-benchmarking to 0.5.1 (#13310)
* update nalgebra in frame-benchmarking to 0.5.0
* upgrade to 0.5.1 to incorporate upstream fix in linregress
* [client/network] remove peer entry from `ephemeral_addresses` (#13084)
* [client/network] remove peer entry from `ephemeral_addresses`
if there are no addresses associated with that peer
* refactor as per @bkchr suggestion
https://github.com/paritytech/substrate/pull/13084#discussion_r1068028534
* add missing import
* fix error
* rpc-spec-v2/tx: Fix error typo (#13307)
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* BEEFY: client support for detecting equivocated votes (#13285)
* client/beefy: detect equivocated votes
* client/beefy: make sure to persist state after voting
* client/beefy: drop never-used aux-schema v2 migration
* impl review suggestion
---------
Signed-off-by: Adrian Catangiu <adrian@parity.io>
* Bump `wasmtime` to 5.0.0 (and a few other deps) (#13160)
* Bump `wasmtime` to 4.0.0 (and a few other deps)
* Use `Error::msg` instead of `anyhow!`
* Bump `wasmtime` to 5.0.0
* Update `Cargo.lock`
* Add `wasmtime` feature to `sp-wasm-interface` dependency
* Fix: Off-chain-worker example (#13300)
* fix: divider
* update comment
* Rename `pallet-random-collective-flip` to Insecure... (#13301)
* Rename pallet-random-collective-flip to Insecure...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* `zombienet`: warp-sync tests for validators (#13078)
* zombienet validators warp sync draft
Sketch of warp-sync test for validators.
Not tested.
Follow-up of: #12769
* yet another warp-sync scenario added
- all validators are synced from DB,
- some full nodes are synced from DB,
- full-node is warp-synced
* fixes
* fixes
* missing files
* path fixed
---------
Co-authored-by: parity-processbot <>
* Disable default features for `strum` (#13326)
* Fix block pruning (#13323)
* Fix block pruning (#13323)
* Referendum proposal's metadata (#12568)
* referenda metadata
* todo comment
* remove TODO, update rustdocs
* referenda clear_metadata origin signed or root
* referenda metadata unit tests
* drop schema type for referenda metadata
* remove metadata type
* referenda metadata benches
* note different preimages
* metadata for democracy pallet
* metadata democracy pallet tests and benches
* fix cargo clippy
* update docs
* ".git/.scripts/bench-bot.sh" pallet dev pallet_democracy
* ".git/.scripts/bench-bot.sh" pallet dev pallet_referenda
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
* Update the doc frame/democracy/src/lib.rs
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>
* reference instead clone for take
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>
* error rename BadMetadata to PreimageNotExist
* clear metadata within internal_cancel_referendum fn
* remove redundant clone
* collapse metadata api into one set_metadata method
* fmt
* review fixes
* not request preimage on set_metadata
* rename events and update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_democracy
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_referenda
* rename reset_metadata to transfer_metadata
---------
Co-authored-by: command-bot <>
Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
Co-authored-by: Anthony Alaribe <anthonyalaribe@gmail.com>
* Improve test coverage of the `Notifications` protocol (#13033)
* Add handler and upgrade tests
* Add tests for `behaviour.rs`
* Apply review comments
* Update dependencies
* Apply suggestions from code review
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
* Apply review comments
* Fix clippy
* Update mockall
* Apply review comment
---------
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
* Configurable voting-degree in council elections pallet (#13305)
* configurable council elections pallet
* configurable council elections pallet
* add warning
* reduce sizes
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_elections_phragmen
* fix stuff
* make assert
* fix docs
* fix docs again
* fix docs again
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
* Update frame/elections-phragmen/src/lib.rs
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
* fix docs
---------
Co-authored-by: command-bot <>
Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
* Rework generated API docs (#13178)
* pallet-scheduler: Ensure we request a preimage (#13340)
* pallet-scheduler: Ensure we request a preimage
The scheduler was not requesting a preimage. When a preimage is requested, a user can deposit it
without paying any fees.
* Review changes
* [Fix] Try-state feature-gated for BagsList (#13296)
* [Fix] Try-state feature-gated for BagsList
* fix comment
* fix try_state remote-tests
* feature-gate try-state remote test for bags-list
* remove try-state from a migration
* more SortedListProvider fixes
* more fixes
* more fixes to allow do_try_state usage in other crates
* do-try-state for fuzz
* more fixes
* more fixes
* remove feature-flag
* do-try-state
* fix review comments
* Update frame/bags-list/src/mock.rs
Co-authored-by: Anton <anton.kalyaev@gmail.com>
---------
Co-authored-by: parity-processbot <>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* bump version of zombienet and update snaps links (#13359)
* Fix longest chain finalization target lookup (#13289)
* Finalization target should be chosed as some ancestor of SelectChain::best_chain
* More test assertions
* Improve docs
* Removed stale docs
* Rename 'target' to 'base' in lookup method
* Fix typo
* Apply suggestions from code review
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* Rename 'target_hash' to 'base_hash' in 'SelectChain::finality_target()'
* Apply suggestions from code review
Co-authored-by: Anton <anton.kalyaev@gmail.com>
* Docs improvement
* Doc fix
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* Apply more code suggestions
---------
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
* SetMembers configurable origin (#13159)
* SetMembers configurable origin
* root origin comment replaced
* fmt
* grandpa: don't error if best block and finality target are inconsistent (#13364)
* grandpa: don't error if best block and finality target are inconsistent
* grandpa: add test for best block override
* grandpa: make clippy happy
* grandpa: log selectchain override as debug instead of warn
* grandpa: don't error if best block and finality target are inconsistent (#13364)
* grandpa: don't error if best block and finality target are inconsistent
* grandpa: add test for best block override
* grandpa: make clippy happy
* grandpa: log selectchain override as debug instead of warn
* Improve Weight Template and API (#13355)
* improve weights template and api
* follow template
* [ci] Change label checker (#13360)
* [ci] Change label checker
* rm pr autolabel
* fix specs file name to substrate
* client/beefy: request justifs from peers further in consensus (#13343)
For on-demand justifications, peer selection is based on witnessed
gossip votes. This commit changes the condition for selecting a peer
to request justification for `block` from
"last voted on >= `block`" to "peer last voted on strict > `block`".
When allowing `>=` we see nodes continuously spamming unsuccessful
on-demand requests to nodes which are still voting on a block without
having a justification available.
One way to fix the spam would be to add some rate-limiting or backoff
period when requesting justifications.
The other solution (present in this commit) is to simply request
justifications from peers that are voting on future blocks so we know
they're _guaranteed_ to have the wanted mandatory justification
available to send back.
Signed-off-by: acatangiu <adrian@parity.io>
* [ci] Change GHA to add J2 labels instead Z0 (#13375)
* sc-client-db: Fix `PruningMode::ArchiveCanonical` (#13361)
* sc-client-db: Fix `PruningMode::ArchiveCanonical`
When running a node with `--state-pruning archive-canonical` it was directly failing on genesis.
There was an issue in the state-db `pin` implementation. It was not checking the state of a block
correctly when running with archive canonical (and also not for every other block after they are canonicalized).
* FMT
* benchmarks: EnsureRankedMember must add ranked members (#13297) (#13348)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* subkey: only decode hex if requested, CLI `0x` prefixed hex for all `stdout` (#13258)
* Only decode hex if requested
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Cleanup code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add some tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add license
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Clippy
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* bump version, breaking (tiny) change in output.
* Move integration tests to own folder
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Dan Shields <nukemandan@protonmail.com>
* [Feature] Introduce storage_alias for CountedStorageMap (#13366)
* [Feature] Introduce storagage_alias for CountedStorageMap
* bit more dry
* bit more dry
* address review comments
* some tests and fixes
* fix ui tests
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* compare metadata
---------
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
* [NFTs] Offchain mint (#13158)
* Allow to mint with the pre-signed signatures
* Another try
* WIP: test encoder
* Fix the deposits
* Refactoring + tests + benchmarks
* Add sp-core/runtime-benchmarks
* Remove sp-core from dev deps
* Enable full_crypto for benchmarks
* Typo
* Fix
* Update frame/nfts/src/mock.rs
Co-authored-by: Squirrel <gilescope@gmail.com>
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add docs
* Add attributes into the pre-signed object & track the deposit owner for attributes
* Update docs
* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
* Add the number of attributes provided to weights
* Apply suggestions
* Remove dead code
* Remove Copy
* Fix docs
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update frame/nfts/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* feat: improve FinalityProofProvider api (#13374)
* feat: improve prove_finality api and export it
* fmt
* fix
* improve prove_finality and kept private
* Update client/finality-grandpa/src/finality_proof.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* add `prove_finality_proof` to `FinalityProofProvider`
* fix some and impl Clone for FinalityProofProvider
* improve by suggestions
---------
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* cleanup `<weight></weight>` from docs comments (#13350)
* cleanup <weight></weight> from docs comments
* Changes to address review commnets
* Fix CI cargo test --docs
---------
Co-authored-by: parity-processbot <>
* zombienet: is up timtout increased to 30s (#13386)
* pallet-timestamp: Remove `ValidAtTimestamp` error variant (#13346)
* pallet-timestamp: Remove `ValidAtTimestamp` error variant
The error variant wasn't that useful and it was also used wrongly in the code. In the code we
returned this variant when the `timestamp < minimum`. The problem of this is that we waited on the
node side some time, but then `set` function rejects the timestamp because of the same check (the
timestamp in the block stays the same). We ensure that the timestamp isn't drifting too much in the
future, but waiting for the timestamp to be "valid" would open some attack vector. The consensus
protocols also compare the slots in the blocks to ensure that there isn't a block from the future
and in the runtime we then ensure that `slot = timestamp / slot_duration`. So, we can just remove
this variant and replace it with a new variant `TimeBetweenBlocksTooShort` to not even try importing
a block which uses a too short delay since the last block.
* Update primitives/timestamp/src/lib.rs
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* Rename to `TooEarly`
* FMT
---------
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* add warp to target block for parachains (#12761)
* add warp to target block for parachains
* fix for failing tests
* format using `Cargo +nightly fmt`
* Remove blocking based on PR comments and create new `WarpSync` on poll
* remove method from trait
* add tests for wait for target
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* code refactor based on pr comments
* Second round of PR comments
* Third round of pr comments
* add comments to explain logic
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* code refactor based on last PR comments
* move warp sync polling before `process_outbound_requests`
Add error message if target block fails to be retreived
* Update client/network/sync/src/warp.rs
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com>
* Update client/network/sync/src/lib.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* fmt after code suggestions
* rebase changes
* Bring down the node if the target block fails to return
* Revert "Bring down the node if the target block fails to return"
This reverts commit c0ecb220d66dd8e7b1a5ee29831b776f4f18d024.
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
* Update client/network/common/src/sync/warp.rs
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
* use matching on polling to avoid calling poll more than once
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/sync/src/warp.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* fix typo on comment
* update snapshot with new folder structure
* Upload snapshot
* Bump zombienet
* bump zombienet again
* Improve test
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update client/network/test/src/sync.rs
Co-authored-by: Bastian Köcher <git@kchr.de>
* fix tests
* dummy commit to restart builds
* Converted the target block to an optional value that is set to `None` when an error occurs
* dummy commit to restart builds
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
* [contracts] make `debug_message` execution outcome invariant to node debug logging setting (#13197)
* update benchmark for seal_debug_message
* add seal_debug_message_per_kb benchmark
* un-fallable debug buffer: silently drops excessive and wrong utf-8 encoded messages
* charge debug_message per byte of the message
* impr…
devdanco
added a commit
to gasp-xyz/polkadot
that referenced
this pull request
May 25, 2023
* guide: remove refences to outdated secondary checkers (#6309)
* guide: remove refences to outdated secondary checkers
* Update roadmap/implementers-guide/src/glossary.md
* guide: remove refences to Fisherman
* revert changes to roadmap/parachains.md
* Kusama: approve/reject treasury prop by treasurer (#6354)
* Add buckets on lower end of distribution to network bridge latency metrics (#6359)
* Add two more buckets on lower end of distribution
* add even smaller buckets
* cargo fmt
* Reduce provisioner work (#6328)
* Store values needed to create inherent data when needed instead of creating them early on
* Point deps to substrate branch
* Arc the client
* Cargo update
* Fix main cargo files
* Undo cargo file changes
* Add overseer dep to inherents
* Update deps
* Simplify code
* Update benchmark
* Update node/client/src/benchmarking.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
* Update node/core/parachains-inherent/src/lib.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
* Update node/core/parachains-inherent/src/lib.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
* Revert "Update node/core/parachains-inherent/src/lib.rs"
This reverts commit 8b9555dc2451acfabab173d259e00da2728b7aa2.
* Revert "Update node/core/parachains-inherent/src/lib.rs"
This reverts commit 816c92d0e001e71f677d0acbcf22bdc3f511bc56.
* cargo update -p sp-io
* fmt
Co-authored-by: Bastian Köcher <info@kchr.de>
* update deprecated alias `--all` (#6383)
`--all` is a deprecated alias for `--workspace` (https://doc.rust-lang.org/cargo/commands/cargo-test.html)
* Upgrade tokio to 1.22.0 (#6262)
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
* Set polkadot version in one place (#6095)
* rust 1.64 enables workspace properties
* add edition, repository and authors.
* of course, update the version in one place.
Co-authored-by: Andronik <write@reusable.software>
* Introduce NIS functionality into Kusama/Rococo (#6352)
* Integrate NIS into Kusama/Rococo
* Missing files
* Fix
* Fix
* Formatting
* Add Kusama weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add Rococo weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump
* Bump
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_nis
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_nis
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
* OpenGov improvements for Kusama (#6372)
* Tweaks to optimise gov2
* Use new inactive funds
* Introduce migrations
* Fixes
* Fixes
* Fixes
* Some constant updates for Fellowship
* Further tweaks
* Lower floor for whitelisted
* Tweak some NIS params (#6393)
* Reduce base period, increase queue count
* Reduce base period, increase queue count
* allow root with gov2 origins (#6390)
* Bump Substrate (#6394)
* crowdloan: Fix migration. (#6397)
The migration would not have been run because of the `current_version ==
1` check.
* Companion of Substrate PR 12837 (#6385)
* rename some crates for publishing to crates.io
* s/remote-ext/frame-remote-externalities
* cargo update
* Make submission deposit reasonable (#6402)
* kusama whitelist pallet preimage dep upgrade (#6392)
* Bump (#6404)
* Companion for paritytech/substrate#12795 (#6374)
* Begin removing `parity-util-mem`; remove `collect_memory_stats`
* Update some dependencies that were using `parity-util-mem`
* Remove `trie-memory-tracker` feature
* Update Cargo.lock
* Update `kvdb-shared-tests`
* Add back jemalloc
* Add missing license header
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
Co-authored-by: Andronik <write@reusable.software>
* Let the PVF host kill the worker on timeout (#6381)
* Let the PVF host kill the worker on timeout
* Fix comment
* Fix inaccurate comments; add missing return statement
* Fix a comment
* Fix comment
* Companion for paritytech/substrate#12788 (#6360)
* Companion for paritytech/substrate#12788
* migrations
* rustfmt
* update lockfile for {"substrate"}
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Make sure to preserve backing votes (#6382)
* Guide updates
* Consider more dead forks.
* Ensure backing votes don't get overridden.
* Fix spelling.
* Fix comments.
* Update node/primitives/src/lib.rs
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* Refactoring to condense disputes tests (#6395)
* Refactoring to condense disputes tests
* Removing unhelpful comment lines
* Addressing Tsveto's suggestions
* Fixing formatting nit
* [ci] Adjust check-runtime-migration job (#6107)
* [WIP][ci] Add node to check-runtime-migration job
* add image
* remove sscache from before_script
* add nodes
* restart pipeline
* restart pipeline2
* disable other jobs
* debug
* remove debug
* add ports
* restart pipeline
* restart pipeline
* restart pipeline
* try kusama first
* run polkadot 1st
* disable some jobs
* try command from command bot
* cargo run
* test passing variables
* run without condition
* adjust kusama and westend
* fix
* return jobs
* fix small nits
* split check-runtime-migration
Co-authored-by: parity-processbot <>
* update weights (sync with 0.9.33) (#6362)
* update weights (0.9.33) (#6299)
* kusama: update weights
* polkadot: update weights
* rococo: update weights
* westend: update weights
* fix deps
* Resolve merge
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Reset Kusama whitelist weights
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Feature gate test `benchmark_storage_works` (#6376)
* Feature gate storage bench test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* typo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
* Companion for paritytech/substrate#12868 (#6406)
* Replace WEIGHT_PER_* with WEIGHT_REF_TIME_PER_*
* cargo fmt
* Update substrate
* OpenGov: Tweak parameters further (#6416)
* Tweak parameters further
* Further tweaks to deposits
* companion for #12663 jsonrpsee v0.16 (#6339)
* companion for #12663 jsonrpsee v0.16.1
* update substrate
* merge master
* Update rpc/Cargo.toml
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
* Update utils/staking-miner/Cargo.toml
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
* update lockfile for {"substrate"}
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: parity-processbot <>
* CI: Remove the excessive variable declaration (#6426)
* companion slash chilling update (#6424)
* update weights
* goddamit
* update weights
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* swap error responses (#6421)
* [ci] fix check-transaction-versions (#6425)
* [ci] fix check-transaction-versions
* allow fail the job
* approval-distribution: batched approval/assignment sending (#6401)
* Imple batched send
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Add batch tests
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* pub MAX_NOTIFICATION_SIZE
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* spell check
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* spellcheck ...
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Fix comment
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* o.O
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* 2 constants
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Ensure batch size is at least 1 element
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* feedback impl
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* add westend bootnode (#6434)
* [ci] add job switcher (#6433)
* [ci] add job switcher
* add before_script to docker and k8s runners
* upd runners
* sccache :(
* companion for try-runtime revamp (#6187)
* update to reflect latest try-runtime stuff
* update to latest version
* fix
* fix miner
* update
* update
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Fix wrong rate limit + add a few logs. (#6440)
* Add trace log
* More tracing.
* Fix redundant rate limit.
* Add trace log.
* Improve logging.
Co-authored-by: eskimor <eskimor@no-such-url.com>
* Make sure errors get logged (#6451)
instead of silently dropped.
Co-authored-by: eskimor <eskimor@no-such-url.com>
* Adding some more logs (#6455)
* Adding some more logs
More logs are always better! Joke aside, these logs help to debug
certain issues.
* Apply suggestions from code review
* [bump] orchestra v0.0.4 (#6413)
* update orchestra to v0.0.3
* fix locks
* update orchestra to v0.0.4
* update lock
* Use explicit call indices (#6449)
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use explicit call indices
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update Substrate (#6457)
* BlockId removal: refactor: HeaderBackend::header (#6418)
* BlockId removal: refactor: HeaderBackend::header
It changes the arguments of:
- `HeaderBackend::header`,
- `Client::header`
methods from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
* missed fixes
* BlockId removal: refactor: HeaderBackend::expect_header
It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`
* update lockfile for {"substrate"}
* misspell fixed
Co-authored-by: parity-processbot <>
* PVF preparation: do not conflate errors (#6384)
* PVF preparation: do not conflate errors
+ Adds some more granularity to the prepare errors.
+ Better distinguish whether errors occur on the host side or the worker.
+ Do not kill the worker if the error happened on the host side.
+ Do not retry preparation if the error was `Panic`.
+ Removes unnecessary indirection with `Selected` type.
* Add missing docs, resolve TODOs
* Address review comments and remove TODOs
* Fix error in CI
* Undo unnecessary change
* Update couple of comments
* Don't return error for stream shutdown
* Update node/core/pvf/src/worker_common.rs
* [ci] New try-runtime command (#6445)
* [ci] New try-runtime command
* restart pipeline
* build features
* fix --features flag
* rm --execution flag
* remove --no-spec-check-panic flag
* change target dir
* debug ccargo target dir
* return target
* try different location for runtime wasm
* build only the runtime crate
* check all generated .wasm files
* adjust paths again
* remove debug command
Co-authored-by: joao-paulo-parity <joao-paulo@parity.io>
* Kusama origins as xcm multi_location (#6273)
* Kusamsa origins as xcm multilocation
* Fellows origin index
* origins to xcm plurality body
* cleanup
* fix cargo spellcheck
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
* include Fellows into scope
* include Fellows into scope
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Gavin Wood <gavin@parity.io>
* BlockId removal: refactor: HeaderBackend::status (#6459)
* BlockId removal: refactor: HeaderBackend::status
It changes the arguments of `HeaderBackend::status` method from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
* Update node/core/chain-api/src/tests.rs
Co-authored-by: Adrian Catangiu <adrian@parity.io>
* unused import removed
* update lockfile for {"substrate"}
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: parity-processbot <>
* cargo update -p libp2p-yamux (#6464)
* fix dependabot labels (#6468)
* Fix runtime-migration label detection (#6469)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump secp256k1 from 0.24.0 to 0.24.2 (#6411)
Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.24.0 to 0.24.2.
- [Release notes](https://github.com/rust-bitcoin/rust-secp256k1/releases)
- [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/secp256k1-0.24.2/CHANGELOG.md)
- [Commits](https://github.com/rust-bitcoin/rust-secp256k1/compare/secp256k1-0.24.0...secp256k1-0.24.2)
---
updated-dependencies:
- dependency-name: secp256k1
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: parity-processbot <>
* [Companion] Allow StakingAdmin to set min_commission (#6444)
* rename staking origin
* fix comments
* rename origin
* give fake weight before re-benchmarking
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_staking
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_staking
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_staking
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Added comment describing satisfied invariant (#6460)
* Runtime diagnostics for leaked messages in unbounded channels (part 2) (#6481)
* Bump `backtrace` to v0.3.67
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Update disputes subsytems section. (#6329)
* Update disputes subsytems section.
* Update roadmap/implementers-guide/src/node/disputes/README.md
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
* Update roadmap/implementers-guide/src/node/disputes/README.md
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
* Update roadmap/implementers-guide/src/node/disputes/README.md
Co-authored-by: ordian <write@reusable.software>
* Update roadmap/implementers-guide/src/node/disputes/README.md
Co-authored-by: ordian <write@reusable.software>
* Review feedback.
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: ordian <write@reusable.software>
* Update dispute participation on active leaves update (#6303)
* Passed candidate events from scraper to participation
* First draft PR 5875
* Added support for timestamp in changes
* Some necessary refactoring
* Removed SessionIndex from unconfirmed_disputes key
* Removed duplicate logic in import statements
* Replaced queue_participation call with re-prio
* Simplifying refactor. Backed were already handled
* Removed unneeded spam slots logic
* Implementers guide edits
* Undid the spam slots refactor
* Added comments and implementers guide edit
* Added test for participation upon backing
* Round of fixes + ran fmt
* Round of changes + fmt
* Error handling draft
* Changed errors to bubble up from reprioritization
* Starting to construct new test
* Clarifying participation function rename
* Reprio test draft
* Very rough bump to priority queue test draft
* Improving logging
* Most concise reproduction of error on third import
* Add `handle_approval_vote_request`
* Removing reprioritization on included event test
* Removing unneeded test config
* cargo fmt
* Test works
* Fixing final nits
* Tweaks to test Tsveto figured out
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
* BlockId removal: refactor: BlockBackend::block|block_status (#6477)
* BlockId removal: refactor: BlockBackend::block|block_status
It changes the arguments of:
- `BlockBackend::block`
- `BlockBackend::block_status`
method from: `BlockId<Block>` to: `Block::Hash`
This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
* update lockfile for {"substrate"}
* ".git/.scripts/fmt.sh"
Co-authored-by: parity-processbot <>
* Deploy scheduler agenda cleanup migration (#6465)
* Add migration
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add comments
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Migrate Staking pallet to v13 (#6365)
* add staking v13 migration
* add migration to polkadot
* only migrate staking
* un-remove other migrations
* fmt
* retrigger ci
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Co #13045: Selectable on-runtime-upgrade checks (#6498)
* Use UpgradeCheckSelector
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update lockfile for {"substrate"}
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
* Add `try-runtime` to Rococo runtime (#6501)
* Add `try-runtime` to Rococo runtime
* Enable try-runtime in all pallets
* Update runtime/rococo/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add dev-dependencies for the try-runtime test
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix `polkadot-runtime-constants` std build (#6503)
* Fix polkadot-runtime-constants std build
* Fix kusama, rococo and westend constants std build
* Code review fixes
* Issue 6274: keeping all backing votes in provisioner vote set (#6494)
* Fixing filter to keep all backing votes
* Comment and implementers guide edit
* Formatting
* Using fallthrough
* Fmt
* Log PVF retries (#6504)
* av-store: write meta for unknown finalized blocks (#6452)
* av-store: write meta for unknown finalized blocks
* fix test
* upgrade libp2p to 0.50.0 (#6500)
* update asynchronous-codec
* update futures-rustls
* update rustls
* update ipnet
* update once_cell
* update futures
* update futures and its deps
* update lockfile for {"substrate"}
* Bump zombienet test timeout from 30 to 60 s
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Revert "Bump zombienet test timeout from 30 to 60 s"
This reverts commit 657738dfffe3234195a3b5b491f08e4660ca7bad.
* Update Substrate
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
* Update serde because substrate->trybuild needs a newer version (#6505)
companion PR for https://github.com/paritytech/substrate/pull/13073
* [ci] Remove check-transaction-versions job (#6509)
Co-authored-by: parity-processbot <>
* Unlimited Proof size per block (#6085)
* Unlimited Proof size per block
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use `polkadot-node-metrics` where possible (#6484)
See https://github.com/paritytech/polkadot/issues/6015. (Doesn't close yet,
there might be more we can do.)
* disputes pallet: Remove spam slots (#6345)
* disputes pallet: Filter disputes with votes less than supermajority threshold
* Remove `max_spam_slots` usages
* Remove `SpamSlots`
* Remove `SpamSlotChange`
* Remove `Error<T>::PotentialSpam` and stale comments
* `create_disputes_with_no_spam` -> `create_disputes`
* Make tests compile - wip commit
* Rework `test_dispute_timeout`. Rename `update_spam_slots` to `filter_dispute_set`
* Remove `dispute_statement_becoming_onesided_due_to_spamslots_is_accepted` and `filter_correctly_accounts_spam_slots` -> they bring no value with removed spam slots
* Fix `test_provide_multi_dispute_success_and_other`
* Remove an old comment
* Remove spam slots from tests - clean todo comments
* Remove test - `test_decrement_spam`
* todo comments
* Update TODO comments
* Extract `test_unconfirmed_are_ignored` as separate test case
* Remove dead code
* Fix `test_unconfirmed_are_ignored`
* Remove dead code in `filter_dispute_data`
* Fix weights (related to commit "Remove `SpamSlots`")
* Disputes migration - first try
* Remove `dispute_max_spam_slots` + storage migration
* Fix `HostConfig` migration tests
* Deprecate `SpamSlots`
* Code review feedback
* add weight for storage version update
* fix bound for clear()
* Fix weights in disputes migration
* Revert "Deprecate `SpamSlots`"
This reverts commit 8c4d967c7b061abd76ba8b551223918c0b9e6370.
* Make mod migration public
* Remove `SpamSlots` from disputes pallet and use `storage_alias` in the migration
* Fix call to `clear()` for `SpamSlots` in migration
* Update migration and add a `try-runtime` test
* Add `pre_upgrade` `try-runtime` test
* Fix some test names in `HostConfiguration` migration
* Link spamslots migration in all runtimes
* Add `test_unconfirmed_disputes_cause_block_import_error`
* Update guide
- Remove `SpamSlots` related information from roadmap/implementers-guide/src/runtime/disputes.md
- Add 'Disputes filtering' to Runtime section of the Implementor's guide
* Update runtime/parachains/src/configuration/migration.rs
Co-authored-by: Marcin S. <marcin@bytedude.com>
* Code review feedback - update logs
* Code review feedback: fix weights
* Update runtime/parachains/src/disputes.rs
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
* Additional logs in disputes migration
* Fix merge conflicts
* Add version checks in try-runtime tests
* Fix a compilation warning`
Co-authored-by: Marcin S. <marcin@bytedude.com>
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
* Remove unused code (#6525)
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Fix flaky test in `dispute-coordinator` (#6524)
https://github.com/paritytech/polkadot/pull/6494 updates disputes
participation priority on Active Leaves update. This operation might
trigger participation in some cases and as a result some of the message
ordering is not as nice as it used to be.
As a side effect of this `resume_dispute_without_local_statement` was
failing occasionally. The solution is not to expect that `BlockNumber`,
`CandidateEvents`, `FetchOnChainVotes` and `Ancestors` messages are
executed after `FinalizedBlockNumber` and in any specific order.
This should be okay as the code is in helper function and doesn't affect
the actual test behaviour.
Fixes https://github.com/paritytech/polkadot/issues/6514
* Bump tokio from 1.22.0 to 1.24.1 (#6523)
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.22.0 to 1.24.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.22.0...tokio-1.24.1)
---
updated-dependencies:
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Guide changes 3 (#6520)
* Guide changes
* Adding clarification
* Replace async-std with tokio in PVF subsystem (#6419)
* Replace async-std with tokio in PVF subsystem
* Rework workers to use `select!` instead of a mutex
The improvement in code readability is more important than the thread overhead.
* Remove unnecessary `fuse`
* Add explanation for `expect()`
* Update node/core/pvf/src/worker_common.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
* Update node/core/pvf/src/worker_common.rs
Co-authored-by: Bastian Köcher <info@kchr.de>
* Address some review comments
* Shutdown tokio runtime
* Run cargo fmt
* Add a small note about retries
* Fix up merge
* Rework `cpu_time_monitor_loop` to return when other thread finishes
* Add error string to PrepareError::IoErr variant
* Log when artifacts fail to prepare
* Fix `cpu_time_monitor_loop`; fix test
* Fix text
* Fix a couple of potential minor data races.
First data race was due to logging in the CPU monitor thread even if the
job (other thread) finished. It can technically finish before or after the log.
Maybe best would be to move this log to the `select!`s, where we are guaranteed
to have chosen the timed-out branch, although there would be a bit of
duplication.
Also, it was possible for this thread to complete before we executed
`finished_tx.send` in the other thread, which would trigger an error as the
receiver has already been dropped. And right now, such a spurious error from
`send` would be returned even if the job otherwise succeeded.
* Update Cargo.lock
Co-authored-by: Bastian Köcher <info@kchr.de>
* Fix cycle dispute-coordinator <-> dispute-distribution (#6489)
* First iteration of message sender.
* dyn Fn variant (no cloning)
* Full implementation + Clone, without allocs on `Send`
* Further clarifications/cleanup.
* MessageSender -> NestingSender
* Doc update/clarification.
* dispute-coordinator: Send disputes on startup.
+ Some fixes, cleanup.
* Fix whitespace.
* Dispute distribution fixes, cleanup.
* Cargo.lock
* Fix spaces.
* More format fixes.
What is cargo fmt doing actually?
* More fmt fixes.
* Fix nesting sender.
* Fixes.
* Whitespace
* Enable logging.
* Guide update.
* Fmt fixes, typos.
* Remove unused function.
* Simplifications, doc fixes.
* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Co-authored-by: Marcin S. <marcin@bytedude.com>
* Fmt + doc example fix.
Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Marcin S. <marcin@bytedude.com>
* Update the GHA srtool-actions to the latest version (#6532)
* Minor fixes (#6533)
* Minor fixes
* Fix compile errors
* Trigger update-node-template when a final release tag is created (#6522)
* trigger update-node-template when final release tag is created
ref https://github.com/paritytech/release-engineering/issues/142
* fix comment
* Update scripts/ci/gitlab/pipeline/publish.yml
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
* fix regular expression
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
* ci: mark update-weights non-interruptible (#6539)
* Bump JasonEtco/create-an-issue from 2.6.0 to 2.9.1 (#6473)
Bumps [JasonEtco/create-an-issue](https://github.com/JasonEtco/create-an-issue) from 2.6.0 to 2.9.1.
- [Release notes](https://github.com/JasonEtco/create-an-issue/releases)
- [Commits](https://github.com/JasonEtco/create-an-issue/compare/9e6213aec58987fa7d2f4deb8b256b99e63107a2...e27dddc79c92bc6e4562f268fffa5ed752639abd)
---
updated-dependencies:
- dependency-name: JasonEtco/create-an-issue
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: parity-processbot <>
* Improve inactive fund tracking (#6471)
* Improve inactive fund tracking
* Docs
* Introduce the re-migration code
* Bump
* Update runtime/kusama/src/lib.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update runtime/common/src/crowdloan/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update runtime/common/src/crowdloan/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Grumbles
* Apply comments suggestions from code review
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: parity-processbot <>
* Re-export current primitives in crate root (#6487)
* Re-export current primitives in crate root
* Add missing exports
* restart CI
* Add a paragraph about slashing in runtime disputes section from the guide (#6531)
* Add a paragraph about slashing in runtime disputes section from the guide
* Add definition for inconclusive
* Westend state trie to version 1 (#6336)
* Switch to state V1 and add state-trie-migration pallet with dummy manual
account.
* Initialize limit on runtime upgrade.
* add prelude
* sp_std prelude only for no_std
* Disable filter for signed migration
* revert hex dep
* use NeverEnsureOrigin
* fix
* correct fix
* check init state in try-runtime
Co-authored-by: parity-processbot <>
* handle substrate-node-template and substrate-parachain-template (#6541)
* Updated Dwellir bootnodes. Now using wss. (#6534)
* pvf: Fix missing execution request when retrying preparation (#6537)
* pvf: Add checks for result sender when retrying preparation in tests
* pvf: Fix missing execution request when retrying preparation
* Update comment
* pre-checking: Reject failed PVFs (#6492)
* pre-checking: Reject failed PVFs
* paras: immediately reject any PVF that cannot reach a supermajority
* Make the `quorum` reject condition a bit more clear semantically
* Add comment
* Update implementer's guide
* Update a link
Not related to the rest of the PR, but I randomly noticed and fixed this.
* Update runtime/parachains/src/paras/tests.rs
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
* Remove unneeded loop
* Log PVF retries using `info!`
* Change retry logs to `warn!` and add preparation failure log
* Log PVF execution failure
* Clarify why we reject failed PVFs
* Fix PVF reject runtime benchmarks
Co-authored-by: s0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
* Fix set-output deprecation (#6554)
set-output is being deprecated by GH.
More information at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
* add erasure-coding benches (#6308)
* add erasure-code benches
* revert Cargo.lock changes
* revert Cargo.lock changes
* CI: Code mark to request a pipeline failure (#6562)
* XCM v3 (#4097)
* cargo fmt
* Create benchmarks for XCM instructions introduced in v3 (#4564)
* Create benchmarks for BurnAsset and ExpectAsset
* Add benchmarks for ExpectOrigin and ExpectError
* Add benchmarks for QueryPallet and ExpectPallet
* Add benchmarks for ReportTransactStatus and ClearTransactStatus
* cargo fmt
* Use AllPalletsWithSystem in mocks
* Update XCM generic benchmarks for westend
* Remove default impls for some XCM weight functions
* Fix compilation error
* Add weight_args helper attribute
* Remove manually written XcmWeightInfo
* Parse trailing comma
* Revert "Add weight_args helper attribute"
This reverts commit 3b7c47a6182e1b9227036c38b406d494c3fcf6fd.
* Fixes
* Fixes
* XCM v3: Introduce querier field into `QueryReponse` (#4732)
* Introduce querier field into QueryReponse
* Convert &Option<MultiLocation> to Option<&MultiLocation>
&Option<T> is almost always never quite useful, most of the time it
still gets converted to an Option<&T> via `as_ref`, so we should simply
make functions that accept Option<&T> instead.
* Fix tests
* cargo fmt
* Fix benchmarks
* Appease spellchecker
* Fix test
* Fix tests
* Fix test
* Fix mock
* Fixes
* Fix tests
* Add test for response queriers
* Update xcm/pallet-xcm/src/lib.rs
* Test for non-existence of querier
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Fixes
* Fixes
* Add `starts_with` function to `MultiLocation` and `Junctions` (#4835)
* add matches_prefix function to MultiLocation and Junctions
* rename matches_prefix to starts_with
* remove unnecessary main in doc comment
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* Make use of starts_with in match_and_split
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* XCM v3: Bridge infrastructure (#4681)
* XCM bridge infrastructure
* Missing bit of cherry-pick
* Revamped XCM proc macros; new NetworkIds
* Fixes
* Formatting
* ExportMessage instruction and config type
* Add MessageExporter definitions
* Formatting
* Missing files
* Fixes
* Initial bridging config API
* Allow for two-stage XCM execution
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* XCM crate building again
* Initial bridging primitive
* Docs
* Docs
* More work
* More work
* Merge branch 'gav-xcm-v3' into gav-xcm-v3-bridging
* Make build
* WithComputedOrigin and SovereignPaidRemoteExporter
* Remove TODOs
* Slim bridge API and tests.
* Fixes
* More work
* First bridge test passing
* Formatting
* Another test
* Next round of bridging tests
* Repot tests
* Cleanups
* Paid bridging
* Formatting
* Tests
* Spelling
* Formatting
* Fees and refactoring
* Fixes
* Formatting
* Refactor SendXcm to become two-phase
* Fix tests
* Refactoring of SendXcm and ExportXcm complete
* Formatting
* Rename CannotReachDestination -> NotApplicable
* Remove XCM v0
* Minor grumbles
* Formatting
* Formatting
* Fixes
* Fixes
* Cleanup XCM config
* Fee handling
* Fixes
* Formatting
* Fixes
* Bump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Bump Substrate
* XCM v3: `ExchangeAsset` and Remote-locking (#4945)
* Asset Exchange and Locks
* Make sure XCM typers impl MaxEncodedLen
* Basic implementation for locks
* Bump Substrate
* Missing files
* Use new API
* Introduce instruction
* Big refactor
* Docs
* Remove deprecated struct
* Remove deprecated struct
* Repot XCM builder tests
* ExchangeAsset test
* Exchange tests
* Locking tests
* Locking tests
* Fixes and tests
* Fixes
* Formatting
* Spelling
* Add simulator test for remote locking
* Fix tests
* Bump
* XCM v3: Support for non-fungibles (#4950)
* NFT support and a test
* New files.
* Integration tests for sending NFTs
* Formatting
* Broken Cargo features
* Use 2021 edition
* Fixes
* Formatting
* Formatting
* Update xcm/xcm-builder/src/asset_conversion.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update xcm/xcm-builder/src/nonfungibles_adapter.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update xcm/xcm-executor/src/lib.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* XCM v3: Context & ID hash (#4756)
* send_xcm returns message hash
* cargo fmt
* Create topic register and instructions
* Fix weights
* Use tabs
* Sketch out XcmContext
* Fix doc test
* Add the XCM context as a parameter to executor trait fns
* Fixes
* Add XcmContext parameter
* Revert adding context as an arg to SendXcm trait methods
* Revert adding context argument to ConvertOrigin trait methods
* cargo fmt
* Do not change the API of XcmExecutor::execute
* Fixes
* Fixes
* Fixes
* Fixes
* Remove convenience method
* Fixes
* Fixes
* cargo fmt
* Fixes
* Add benchmarks for XCM topic instructions
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Remove context argument on FilterAssetLocation
* Fixes
* Remove unused import
* Fixes
* Fixes
* Fixes
* Accept XCM hash parameter in ExecuteXcm trait methods
* cargo fmt
* Properly enable sp-io/std
* Fixes
* default-features = false
* Fixes
* Fixes
* Fixes
* Make XcmContext optional in withdraw_asset
* Fixes
* Fixes
* Fixes
* Modify tests to check for the correct XCM hash
* Small refactor
* cargo fmt
* Check for expected hash in xcm-builder unit tests
* Add doc comment for the optionality of the XCM context in withdraw_asset
* Update xcm/src/v3/traits.rs
* Update xcm/src/v3/traits.rs
* Store XcmContext and avoid rebuilding
* Use ref for XcmContext
* Formatting
* Fix incorrect hash CC @KiChjang
* Refactor and make clear fake hashes
* Fixes
* Fixes
* Fixes
* Fix broken hashing
* Docs
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Fixes
* Fixes
* Remove unknowable hash
* Formatting
* Use message hash for greater identifiability
* Formatting
* Fixes
* Formatting
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>
* Fixes
* Fixes
* Fixes
* Fixes
* Formatting
* Fixes
* Formatting
* Fixes
* Fixes
* Formatting
* Formatting
* Remove horrible names
* Bump
* Remove InvertLocation trait (#5092)
* Remove InvertLocation trait
* Remove unneeded functions
* Formatting
* Fixes
* Remove XCMv1 (#5094)
* Remove XCMv1
* Remove XCMv1
* Formatting
* Fixes
* Fixes
* Formatting
* derive serialize/deserialize for xcm primitives (#5036)
* derive serialize/deserialize for xcm primitives
* derive serialize/deserialize for xcm primitives
* update v3
* update v2
Co-authored-by: Gav Wood <gavin@parity.io>
* Update lock
* Fixes
* Add benchmarks for the ExchangeAsset instruction
* `AliasOrigin` instruction stub (#5122)
* AliasOrigin instruction stub
* Fixes
* Fixes
* Update substrate
* Fixes
* Ensure same array length before using copy_from_slice
* Fixes
* Add benchmarks for the UniversalOrigin instruction
* Remove unused import
* Remove unused import
* Add benchmarks for SetFeesMode instruction
* Add benchmarks for asset (un)locking instructions
* Leave AliasOrigin unbenchmarked
* Fixes after merge
* cargo fmt
* Fixes
* Fixes
* Set TrustedReserves to None on both Kusama and Westend
* Remove extraneous reserve_asset_deposited benchmark
* Fix universal_origin benchmark
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Don't rely on skipped benchmark functions
* Fixes
* cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
* Fix unused variables
* Fixes
* Spelling
* Fixes
* Fix codec index of VersionedXcm
* Allows to customize how calls are dispatched from XCM (#5657)
* CallDispatcher trait
* fmt
* unused import
* fix test-runtime
* remove JustDispatch type
* fix typo in test-runtime
* missing CallDispatcher
* more missing CallDispatcher
* Update comment `NoteAssetLocked` -> `NoteUnlockable`
* Fixes
* Fixes
* Adjust MultiAssets weights based on new wild card variants
* Fixes
* Fixes
* Fixes
* Fixes
* Fixes
* Some late fixes for XCMv3 (#5237)
* Maximise chances that trapped assets can be reclaimed
* Do origin check as part of ExportMessage for security
* Formatting
* Fixes
* Cleanup export XCM APIs
* Formatting
* Update xcm/src/v3/junctions.rs
* UnpaidExecution instruction and associated barrier.
* Tighten barriers (ClearOrigin/QueryResponse)
* Allow only 1 ClearOrigin instruction in AllowTopLevelPaidExecutionFrom
* Bi-directional teleport accounting
* Revert other fix
* Build fixes]
* Tests build
* Benchmark fixes
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update Substrate
* Re-export `pub` stuff from universal_exports.rs + removed unecessary clone (#6145)
* Re-export `pub` stuff from universal_exports.rs
* Removed unnecessary clone
* Use 2D weights in XCM v3 (#6134)
* Depend upon sp-core instead of sp-runtime
* Make sp-io a dev-dependency
* Use 2D weights in XCM v3
* cargo fmt
* Add XCM pallet migration to runtimes
* Use from_parts
* cargo fmt
* Fixes
* cargo fmt
* Remove XCMWeight import
* Fixes
* Fixes
* Fixes
* Fixes
* Use translate in migration
* Increase max upward message size in tests
* Fix doc test
* Remove most uses of from_ref_time
* cargo fmt
* Fixes
* Fixes
* Add extrinsic benchmarking to XCM pallet
* cargo fmt
* Fixes
* Use old syntax
* cargo fmt
* Fixes
* Remove hardcoded weights
* Add XCM pallet to benchmarks
* Use successful origin
* Fix weird type parameter compilation issue
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Use benchmarked XCM pallet weights
* Fixes
* Fixes
* Use override instead of skip
* Fixes
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
Co-authored-by: command-bot <>
* Replace Weight::MAX with 100b weight units
* Add test to ensure all_gte in barriers is correct
* Update xcm/src/v3/junction.rs
Co-authored-by: asynchronous rob <rphmeier@gmail.com>
* Add more weight tests
* cargo fmt
* Create thread_local in XCM executor to limit recursion depth (#6304)
* Create thread_local in XCM executor to limit recursion depth
* Add unit test for recursion limit
* Fix statefulness in tests
* Remove panic
* Use defer and environmental macro
* Fix the implementation
* Use nicer interface
* Change ThisNetwork to AnyNetwork
* Move recursion check up to top level
* cargo fmt
* Update comment
Co-authored-by: Bastian Köcher <info@kchr.de>
* Add upper limit on the number of overweight messages in the queue (#6298)
* Add upper limit on the number of ovwerweight messages in the queue
* Add newline
* Introduce whitelist for Transact and limit UMP processing to 10 messages per block (#6280)
* Add SafeCallFilter to XcmConfig
* Limit UMP to receive 10 messages every block
* Place 10 message limit on processing instead of receiving
* Always increment the message_processed count whenever a message is processed
* Add as_derivative to the Transact whitelist
* cargo fmt
* Fixes
* Update xcm/xcm-builder/src/universal_exports.rs
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
* Fixes
* Fixes
* Remove topic register and instead use the topic field in XcmContext
* Derive some common traits for DispatchBlobError
* Fixes
* cargo fmt
* Fixes
* Fixes
* Fix comments
* Fixes
* Introduce WithOriginFilter and apply it as the CallDispatcher for runtimes
* Fixes
* Appease clippy and fixes
* Fixes
* Fix more clippy issues
* Fixes
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* Add benchmark function for ExportMessage
* Fix comment
* Add upper limit to DownwardMessageQueues size
* Add max size check for queue in can_queue_downward_message
* Fixes
* Make Transact runtime call configurable
* Return Weight::MAX when there is no successful send XCM origin
* Update substrate
* Fixes
* Fixes
* Remove ExportMessage benchmark
* Remove assertion on Transact instruction benchmark
* Make reachable destination configurable in XCM pallet benchmarks
* Fixes
* Fixes
* Remove cfg attribute in fuzzer
* Fixes
* Remove cfg attribute for XCM pallet in test runtime
* Fixes
* Use ReachableDest where possible
* Fixes
* Add benchmark for UnpaidExecution
* Update substrate
* Ensure benchmark functions pass filters
* Add runtime-benchmarks feature to fuzzer
* Ensure FixedRateOfFungible accounts for proof size weights
* cargo fmt
* Whitelist remark_with_event when runtime-benchmarks feature is enabled
* Use remark_with_event for Transact benchmarks
* Fix Cargo.lock
* Allow up to 3 DescendOrigin instructions before UnpaidExecution
* cargo fmt
* Edit code comment
* Check check_origin for unpaid execution privilege
* Fixes
* Small nits for xcm-v3 (#6408)
* Add possibility to skip benchmark for export_message
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Revert
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
* Add HaulBlobError to `fn haul_blob`
* ".git/.scripts/bench-bot.sh" xcm westend-dev pallet_xcm_benchmarks::generic
Co-authored-by: command-bot <>
* Revert changes to UnpaidExecution
* Change AllowUnpaidExecutionFrom to be explicit
* Fix log text
* cargo fmt
* Add benchmarks for XCM pallet version migration (#6448)
* Add benchmarks for XCM pallet version migration
* cargo fmt
* Fixes
* Fixes
* Fixes
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
* Fix benchmarks
* Fix benchmarks
* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_xcm
* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_xcm
Co-authored-by: command-bot <>
* Merge remote-tracking branch 'origin/master' into gav-xcm-v3
* Fixes
* Fix comments (#6470)
* Specify Ethereum networks by their chain id (#6286)
Co-authored-by: Squirrel <gilescope@gmail.com>
* Use for Kusama
* Use WithComputedOrigin for Polkadot, Rococo and Westend
* Update lock
* Fix warning
* Update xcm/pallet-xcm/src/tests.rs
Co-authored-by: Squirrel <gilescope@gmail.com>
* Update runtime/parachains/src/ump/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Update xcm/pallet-xcm/src/migration.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fixes
* cargo fmt
* Typo
* Update xcm/src/v3/mod.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Docs
* Docs
* Docs
* Docs
* Docs
* Update xcm/src/v3/multiasset.rs
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add tests for MultiAssets::from_sorted_and_deduplicated
* Fail gracefully when same instance NFTs are detected during push
* Update Substrate to fix benchmarks
* Apply suggestions from code review
* Update runtime/kusama/src/xcm_config.rs
* Rename arguments
* Attempt to fix benchmark
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev runtime_parachains::ump
* Use actual weights for UMP pallet in Polkadot
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime westend-dev runtime_parachains::ump
* ".git/.scripts/commands/bench/bench.sh" runtime rococo-dev runtime_parachains::ump
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Parity Bot <admin@parity.io>
Co-authored-by: stanly-johnson <stanlyjohnson@outlook.com>
Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: asynchronous rob <rphmeier@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Add runtime-benchmarks feature to test client and test service (#6566)
* Exclude CI related dictionary files from the CI team approval (#6563)
* Enable treasury.spend by Root origin for Polkadot network before Gov2 (#6490)
* Enable treasury.spend by Root origin
* EnsureRoot -> EnsureRootWithSuccess
* Co #12928: NIS should retain funds in reserve (#6569)
* Add new weight functions
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Configure NIS pallet ReserveId
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Bump
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Gav <gavin@parity.io>
* Allow AuctionAdmin to use Scheduler (#6573)
* Companion for substrate#13154 (#6570)
* Remove lifetime from `KeyIterator`
* Remove the lifetime from the method too
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Added `HaulBlobError` to pub re-exports (#6579)
* Issue 4804: Notify chain selection of concluded disputes directly (#6512)
* Setting up new ChainSelectionMessage
* Partial first pass
* Got dispute conclusion data to provisioner
* Finished first draft for 4804 code
* A bit of polish and code comments
* cargo fmt
* Implementers guide and code comments
* More formatting, and naming issues
* Wrote test for ChainSelection side of change
* Added dispute coordinator side test
* FMT
* Addressing Marcin's comments
* fmt
* Addressing further Marcin comment
* Removing unnecessary test line
* Rough draft addressing Robert changes
* Clean up and test modification
* Majorly refactored scraper change
* Minor fixes for ChainSelection
* Polish and fmt
* Condensing inclusions per candidate logic
* Addressing Tsveto's comments
* Addressing Robert's Comments
* Altered inclusions struct to use nested BTreeMaps
* Naming fix
* Fixing inclusions struct comments
* Update node/core/dispute-coordinator/src/scraping/mod.rs
Add comment to split_off() use
Co-authored-by: Marcin S. <marcin@bytedude.com>
* Optimizing removal at block height for inclusions
* fmt
* Using copy trait
Co-authored-by: Marcin S. <marcin@bytedude.com>
* XCM: `ExpectTransactStatus` instruction (#6578)
* Introduce ExpectTransactStatus instruction
* Remove other changes
* Implement
* Implement rest
* Benchmark
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* Update xcm/src/v3/mod.rs
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
* construct mmr leaf prior to session pallet hook (#6577)
* move pallet_mmr ahead of pallet_session
addresses #11797
* document construction of mmr leaf prior to session
* update weights (0.9.37) (#6546) (#6555)
* kusama: update weights
* polkadot: update weights
* westend: update weights
* rococo: update weights
* Companion for Substrate #13157 (#6582)
* Update getrandom and version_check
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Companion for substrate: Make DispatchError impl MEL (#6583)
* bump parity-scale-codec version
* update lockfile for {"substrate"}
Co-authored-by: parity-processbot <>
* Update changelog templates to use new labels (#6585)
* Update changelog template to use new T labels
* update readme
* changelog gen: remove T6
* sync versions with release branch (0.9.37) (#6556)
* sync version to current release (0.9.37)
* sync spec_version with current release (9370)
* sync transaction_version with current release (9370)
* Disallow decoding of phantom asset (#6597)
* Disallow decoding of phantom asset
* Remove pub
* remove references to rpm (#6595)
* Warn validators with slow hardware (#6269)
* Warn validators with slow hardware
* update
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix printing logic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* fix
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* add deps
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* update lockfile for {"substrate"}
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Add Polkadotters bootnodes for Westend, Kusama and Polkadot (#6476)
* Add Polkadotters bootnodes for Westend, Kusama and Polkadot
* Remove newlines in bootnodes config section
* Fix some unjustified disputes (#6103)
* Fix indentation + add warning
on participation errors.
* Don't vote invalid on internal errors.
* Don't dispute on code compression error.
* Remove CodeDecompressionError
* Candidate not invalid if PVF preparation fails.
Instead: Report error.
* Fix malus
* Add clarifying comment.
* cargo fmt
* Fix indentation.
* Bump lru from 0.8.1 to 0.9.0 (#6538)
Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.8.1 to 0.9.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.8.1...0.9.0)
---
updated-dependencies:
- dependency-name: lru
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [ci] Change check-labels GHA (#6594)
* [ci] Change check-labels GHA
* change file spec name
* change script when no label
* add tags
* XCM: Add HRMP to SafeCallFilter (#6606)
* XCM: Add HRMP to SafeCallFilter
* Whitelist several paras_registrar calls
* libc crate update (#6616)
cargo update -p libc
* Bump parity-db (#6617)
* New runners for weights and new weights (#6508)
* [DO NOT MERGE] test new vm runner for weights 2
* add image
* fix merge conflict
* apply weights
* new weights
Co-authored-by: parity-processbot <>
* nix upgrade to 0.26.1 (#6622)
* Add pov_size and code_size histograms (#6633)
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
* Enable `try-runtime` flag in CI (#6587)
* Env gate tests
The CI should check that it compiles, but not run it.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Enable try-runtime feature in CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix test
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix XCM transact bench (#6635)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* clear migrations included in 0.9.37 (#6630)
* polkadot: clear migrations included in 0.9.37
* rococo: clear migrations included in 0.9.37
* westend: clear migrations included in 0.9.37
* kusama: clear migrations included in 0.9.37
* remove unused import: xcm_config::CheckAccount
* Co reducing fast-unstake bench time and more (#6552)
* update stuff
* remove
* update
* update
* update weights
* fix tests
* update weights
* fix a few small things
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev pallet-fast-unstake
* reduce batch size
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* update
* fix
* fix
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* update lockfile for {"substrate"}
* fmt
* Env gate migration try_fast_unstake_all
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* 13110 Companion: Add WeightToFee and LengthToFee Runtime API (#6536)
* Add WeightToFee runtime API impls
* Forgot a couple
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Use master Cargo.lock
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* cargo update -p sp-io
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Storage monitor added to polkadot node (#6619)
* Storage monitor added to polkadot node
Related to: https://github.com/paritytech/substrate/issues/12399
* Cargo.lock updated
* Cargo.lock update
* Revert "Cargo.lock update"
This reverts commit 04dfe5fe65ea7d1476d4632ad647f2c1c669ab1a.
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <info@kchr.de>
* missing_docs fixes
* Cargo.lock updated
---------
Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
* Make zombienet tests native friendly (#6588)
* Make zombienet tests native friendly
* Update zombienet_tests/README.md
Co-authored-by: Bastian Köcher <info@kchr.de>
* Get rid of `{{ZOMBIENET_NATIVE_BINARY_PREFIX}}`
* Remove pointless changes
* add set_env helper and doc in readme
* changes from feedback
---------
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Javier Viola <javier@parity.io>
* Companion: Remove `uncles` related code (#6615)
* Companion: Remove `uncles` related code
https://github.com/paritytech/substrate/pull/13216
* Fix compilation
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
* Update benchmark's successful origin api (#6598)
* Update benchmark's successful origin api
* rustfmt
* unwrap for indirect origin dep
* replace unwrap by expect with a message
---------
Co-authored-by: parity-processbot <>
* companion for substrate #13237 (#6626)
* companion for https://github.com/paritytech/substrate/pull/13237
* test-runtime: add MaxSetIdSessionEntries
* update lockfile for {"substrate"}
---------
Co-authored-by: parity-processbot <>
* ignore fast-unstake remote test (#6641)
* Bump docker/build-push-action from 3 to 4 (#6651)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v3...v4)
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Some late short-term fixes for dispute slashing (#6249)
* disputes/slashing: slash only backers for ForInvalid
* add an assertion in mock impl
* fix tests
* do not slash backers on onconcluded disputes
* slash an intersection of backers and losers
* zombienet/disputes: check for offence only for invalid disputes
* add backing votes to disputes bench builder
* Update runtime/parachains/src/builder.rs
* Brad implementers guide revisions 2 (#6239)
* Add disputes subsystems fix
* Updated dispute approval vote import reasoning
* Improved wording of my changes
* Resolving issues brought up in comments
* Update disputes prioritisation in `dispute-coordinator` (#6130)
* Scraper processes CandidateBacked events
* Change definition of best-effort
* Fix `dispute-coordinator` tests
* Unit test for dispute filtering
* Clarification comment
* Add tests
* Fix logic
If a dispute is not backed, not included and not confirmed we
don't participate but we do import votes.
* Add metrics for refrained participations
* Revert "Add tests"
This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0.
* Revert "Unit test for dispute filtering"
This reverts commit 92ba5fe678214ab360306313a33c781338e600a0.
* fix dispute-coordinator tests
* Fix scraping
* new tests
* Small fixes in guide
* Apply suggestions from code review
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
* Fix some comments and remove a pointless test
* Code review feedback
* Clarification comment in tests
* Some tests
* Reference counted `CandidateHash` in scraper
* Proper handling for Backed and Included candidates in scraper
Backed candidates which are not included should be kept for a
predetermined window of finalized blocks. E.g. if a candidate is backed
but not included in block 2, and the window size is 2, the same
candidate should be cleaned after block 4 is finalized.
Add reference counting for candidates in scraper. A candidate can be
added on multiple block heights so we have to make sure we don't clean
it prematurely from the scraper.
Add tests.
* Update comments in tests
* Guide update
* Fix cleanup logic for `backed_candidates_by_block_number`
* Simplify cleanup
* Make spellcheck happy
* Update tests
* Extract candidate backing logic in separate struct
* Code review feedba…
15 tasks
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* companion for paritytech/substrate#13237 * test-runtime: add MaxSetIdSessionEntries * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…13237) * grandpa: cleanup stale entries in set id session mapping * Update frame/grandpa/src/migrations.rs Co-authored-by: Bastian Köcher <git@kchr.de> * grandpa: remove unused import * grandpa: migration off-by-one * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update frame/grandpa/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * grandpa: MaxSetIdSessionEntries as u64 * node-template: fix MaxSetIdSessionEntries type --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GRANDPA pallet we keep a mapping of
set id -> session index, this is necessary to validate equivocation proofs. The entries in this map were never being pruned. This PR bounds the maximum number of entries in this mapping which will usually be set to the bonding duration (in sessions).polkadot companion: paritytech/polkadot#6626