This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update documentation for uniques (This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) #13322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation was outdated after merge of paritytech#11389 Using the widely spread term collections and item instead of the previous class and instance.
simonsso
changed the title
Update documentation for uniques
Update documentation for uniques (This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.)
Feb 7, 2023
ggwpez
added
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
C1-low
labels
Feb 7, 2023
Doesn't the phrase |
Ehh maybe ... looks ok to me but I am (1) a software developer and (2) not a native speaker, so anyone who masters the art of writing for humans may help. |
the-right-joyce
added
C1-low
PR touches the given topic and has a low impact on builders.
and removed
C1-low
labels
Feb 13, 2023
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
jsidorenko
approved these changes
Mar 16, 2023
gilescope
approved these changes
Mar 16, 2023
bot merge |
Error: Statuses failed for a4b00a9 |
@simonsso could you pls merge master into your branch? |
bot merge |
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (#13322) * Update documentation for uniques The documentation was outdated after merge of #11389 Using the widely spread term collections and item instead of the previous class and instance. * Update README.md --------- Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: Jegor Sidorenko <jegor@parity.io>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (paritytech#13322) * Update documentation for uniques The documentation was outdated after merge of paritytech#11389 Using the widely spread term collections and item instead of the previous class and instance. * Update README.md --------- Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: Jegor Sidorenko <jegor@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was outdated after merge of #11389
Using the widely spread term collections and item instead of the previous class and instance.