This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Nfts attribute read interface #13349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsidorenko please take a look :) |
jsidorenko
added
A0-please_review
the-right-joyce
added
B1-note_worthy
joepetrowski
approved these changes
Feb 22, 2023
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
mrshiposha
force-pushed
the
nfts-get-attribute
branch
from
8e749cf
to
7e326bb
Compare
|
I'm sorry for the force push :( |
|
bot merge |
|
Error: Github API says paritytech/cumulus#2217 is not mergeable |
|
bot merge |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* feat: add custom and system attributes to Inspect * feat: add nfts runtime api * fix: pass std feature to runtime api * fix: api copyright Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* feat: add custom and system attributes to Inspect * feat: add nfts runtime api * fix: pass std feature to runtime api * fix: api copyright Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
redzsina
added
D1-audited 👍
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* feat: add custom and system attributes to Inspect * feat: add nfts runtime api * fix: pass std feature to runtime api * fix: api copyright Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the
frame_support::trait::tokens::nonfungible(s)_v2::Inspecttrait:attributenow doesn't take thenamespaceargumentcustom_attributefunctionsystem_attributefunctiontyped-companions are also addedA runtime API is added for the NFTs pallet. The interface is the same as in the
Inspecttrait.Some docs were modified.
Cumulus Companion: paritytech/cumulus#2217