Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: CallApiAt::state_at #13394

Merged
merged 3 commits into from
Feb 16, 2023
Merged

BlockId removal: CallApiAt::state_at #13394

merged 3 commits into from
Feb 16, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Feb 15, 2023 •
edited
Loading

It changes the arguments of:

  • CallApiAt::state_at,
  • Client::code_at,
  • Client::state_at

from: BlockId<Block> to: Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

@michalkucharczyk
BlockId removal: CallApiAt::state_at
6e59f2c 
It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`
@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 15, 2023
@michalkucharczyk michalkucharczyk changed the title BlockId removal: CallApiAt::state_at BlockId removal: CallApiAt::state_at Feb 15, 2023
@michalkucharczyk michalkucharczyk changed the title BlockId removal: CallApiAt::state_at BlockId removal: CallApiAt::state_at Feb 15, 2023
@michalkucharczyk
Copy link
Contributor Author

/cmd queue -c fmt

bkchr
bkchr approved these changes Feb 15, 2023
View reviewed changes
client/service/src/client/client.rs Outdated Show resolved Hide resolved
primitives/api/src/lib.rs Outdated Show resolved Hide resolved
@michalkucharczyk
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 15, 2023 •
edited
Loading

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398752 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 29-d724973a-49a9-4346-84cc-1a5323c9f010 to cancel this command or bot cancel to cancel all commands in this pull request.

@michalkucharczyk @bkchr
Apply suggestions from code review
0889344 
Co-authored-by: Bastian Köcher <git@kchr.de>
@command-bot
Copy link

command-bot bot commented Feb 15, 2023

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398752 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398752/artifacts/download.

@michalkucharczyk
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 15, 2023 •
edited
Loading

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398823 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 30-60cbb5d1-8e15-4688-b110-f7385e4da518 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 15, 2023

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398823 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2398823/artifacts/download.

@michalkucharczyk
Copy link
Contributor Author

bot cancel

@command-bot
Copy link

command-bot bot commented Feb 15, 2023

@michalkucharczyk No task is being executed for this pull request

@michalkucharczyk michalkucharczyk requested a review from a team February 16, 2023 07:15
melekes
melekes approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

primitives/api/test/tests/runtime_calls.rs Show resolved Hide resolved
@michalkucharczyk
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 873fb68 into master Feb 16, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-code_at branch February 16, 2023 22:21
rossbulat pushed a commit that referenced this pull request Feb 19, 2023
@michalkucharczyk @bkchr
BlockId removal: CallApiAt::state_at (#13394)
d7f3acc 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
rossbulat pushed a commit that referenced this pull request Feb 19, 2023
Revert "BlockId removal: CallApiAt::state_at (#13394)"
b60c825 
This reverts commit d7f3acc.
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@michalkucharczyk @bkchr @ltfschoen
BlockId removal: CallApiAt::state_at (paritytech#13394)
a17d0de 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@michalkucharczyk @bkchr @ark0f
BlockId removal: CallApiAt::state_at (paritytech#13394)
94f9e3d 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
Ank4n pushed a commit that referenced this pull request Feb 28, 2023
@michalkucharczyk @bkchr @Ank4n
BlockId removal: CallApiAt::state_at (#13394)
984886f 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@michalkucharczyk @bkchr @ukint-vs
BlockId removal: CallApiAt::state_at (paritytech#13394)
e7aac45 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@michalkucharczyk @bkchr @nathanwhit
BlockId removal: CallApiAt::state_at (paritytech#13394)
8dc3754 
* BlockId removal: CallApiAt::state_at

It changes the arguments of:
- `CallApiAt::state_at`,
- `Client::code_at`,
- `Client::state_at`

from: `BlockId<Block>` to: `Block::Hash`

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalkucharczyk @melekes @bkchr