Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove years from copyright notes. #13415

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Remove years from copyright notes. #13415

merged 5 commits into from
Feb 21, 2023

Conversation

vivekvpandya
Copy link
Contributor

No description provided.

@vivekvpandya vivekvpandya marked this pull request as draft February 18, 2023 10:29
@vivekvpandya vivekvpandya marked this pull request as ready for review February 18, 2023 11:03
@bkchr
Copy link
Member

bkchr commented Feb 18, 2023

Hey thank you for the pr. Could you please remove the years entirely? We discussed this with the lawyers, but don't yet have done the change.

@vivekvpandya
Copy link
Contributor Author

Hey thank you for the pr. Could you please remove the years entirely? We discussed this with the lawyers, but don't yet have done the change.

Oh sorry, I will update the PR as per your suggestion soon.

@vivekvpandya vivekvpandya changed the title Change copyright year to 2023 from 2022 Remove years from copyright notes. Feb 19, 2023
ggwpez
ggwpez approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably get rid of .maintain/update-copyright.sh then.

@ggwpez
Copy link
Member

ggwpez commented Feb 20, 2023

There is one typo on primitives/npos-elections/src/lib.rs the SPDX should be in a new line, like in the other files.

@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 20, 2023
@vivekvpandya
Copy link
Contributor Author

Kindly someone merge this.

@ggwpez
Copy link
Member

ggwpez commented Feb 21, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit e374a33 into paritytech:master Feb 21, 2023
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@vivekvpandya @ltfschoen
Remove years from copyright notes. (paritytech#13415)
674b25f 
* Change copyright year to 2023 from 2022

* Fix incorrect update of copyright year

* Remove years from copy right header

* Fix remaining files

* Fix typo in a header and remove update-copyright.sh
This was referenced Feb 24, 2023
Merged
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@vivekvpandya @ark0f
Remove years from copyright notes. (paritytech#13415)
527d0a0 
* Change copyright year to 2023 from 2022

* Fix incorrect update of copyright year

* Remove years from copy right header

* Fix remaining files

* Fix typo in a header and remove update-copyright.sh
Ank4n pushed a commit that referenced this pull request Feb 28, 2023
@vivekvpandya @Ank4n
Remove years from copyright notes. (#13415)
6ab0c63 
* Change copyright year to 2023 from 2022

* Fix incorrect update of copyright year

* Remove years from copy right header

* Fix remaining files

* Fix typo in a header and remove update-copyright.sh
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@ggwpez ggwpez mentioned this pull request Apr 8, 2023
Merged
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@vivekvpandya @ukint-vs
Remove years from copyright notes. (paritytech#13415)
e5e7732 
* Change copyright year to 2023 from 2022

* Fix incorrect update of copyright year

* Remove years from copy right header

* Fix remaining files

* Fix typo in a header and remove update-copyright.sh
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@vivekvpandya @nathanwhit
Remove years from copyright notes. (paritytech#13415)
d95ef99 
* Change copyright year to 2023 from 2022

* Fix incorrect update of copyright year

* Remove years from copy right header

* Fix remaining files

* Fix typo in a header and remove update-copyright.sh
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@kianenigma kianenigma kianenigma approved these changes

@ggwpez ggwpez ggwpez approved these changes

@athei athei Awaiting requested review from athei athei is a code owner

@acatangiu acatangiu Awaiting requested review from acatangiu acatangiu is a code owner

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@andresilva andresilva Awaiting requested review from andresilva

@koute koute Awaiting requested review from koute koute is a code owner

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivekvpandya @bkchr @ggwpez @shawntabrizi @kianenigma