Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update staking related code-owners #13462

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Update staking related code-owners #13462

merged 1 commit into from
Mar 5, 2023

Conversation

kianenigma
Copy link
Contributor

No description provided.

@kianenigma kianenigma added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Feb 24, 2023
/frame/elections/ @kianenigma
/frame/elections-phragmen/ @kianenigma
/primitives/npos-elections/ @kianenigma
/frame/election-provider-support/ @paritytech/staking-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a warning, but the team is there.. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it for you, the team didn't had "write access to substrate"

@kianenigma kianenigma marked this pull request as ready for review February 24, 2023 14:34
Copy link
Contributor

@gpestana gpestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but getting a warning that @paritytech/staking-core doesn't exist.

@bkchr bkchr merged commit 7d8aa66 into master Mar 5, 2023
@bkchr bkchr deleted the kiz-staking-code-owners branch March 5, 2023 21:38
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants