Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Undeploy insecure randomness pallet #13560

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 8, 2023

Undeploying the insecure randomness pallet from the node-template so that teams don't accidentally have it in the production runtime when using the template.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 8, 2023
ggwpez added 2 commits March 8, 2023 13:04
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@kianenigma kianenigma added B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. and removed B0-silent Changes should not be mentioned in any release notes labels Mar 8, 2023
@ruseinov ruseinov self-requested a review March 9, 2023 12:24
@ggwpez
Copy link
Member Author

ggwpez commented Mar 9, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e46d96c into master Mar 9, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-undeploy-randomness branch March 9, 2023 12:29
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
* Undeploy insecure randomness pallet from node-template

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update lockfile

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove from runtime

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Undeploy insecure randomness pallet from node-template

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update lockfile

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove from runtime

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants