This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[NFTs] Allow to set the role to None #13591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidorenko
added
A0-please_review
gilescope
reviewed
Mar 13, 2023
gilescope
reviewed
Mar 13, 2023
gilescope
approved these changes
Mar 13, 2023
|
bot rebase |
|
Rebased |
|
Curious why there isn’t any change to the logic that checks those roles, since they’re optional now - that should have reflected on the check logic? |
ruseinov
approved these changes
Mar 13, 2023
That's the beauty of that PR :) All the business logic is already in place and was mostly set here: #13482, so now if you remove the Admin role and the previous admin will try to call some admin-related method, the validation won't allow that. |
Only the collection's owner could unset the admin. |
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* Allow to unset the role * Chore * Array instead of vec --------- Co-authored-by: parity-processbot <>
redzsina
added
D1-audited 👍
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Allow to unset the role * Chore * Array instead of vec --------- Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting the Issuer/Admin/Freezer accounts to
Nonewithout the ability to change it back (except for root calls).This is useful for cases when the collection is created, all the items are minted and now we want to be 100% sure no one will mint any more items, or change the metadata, or disable some item's transfer.