Add linguist-generated to gitattributes

[pgherveou]

This will keep generated weights.rs from displaying in diffs by default
see https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github
for more details

[ggwpez]

Then how do we review them?

[pgherveou]

Then how do we review them?

They still show up in the file list, but are by default collapsed, and they don't affect the PR diff numbers, (so people are not scared by a big number when they review your PR)

That's the theory, can try to test this out with this PR to make sure that works as intended

[ggwpez]

That's the theory, can try to test this out with this PR to make sure that works as intended

Less trust, more truth. Let's go!

[ggwpez]

bot bench $ pallet dev pallet_balances
(Bot is probably a bit slow since it i used in other MRs)

[command-bot]

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2542934 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 79-fd955845-a4e5-477a-9a8d-07cd5e60aa91 to cancel this command or bot cancel to cancel all commands in this pull request.

[pgherveou]

noobs question, would that bot call actually create a diff, since this PR has no changes?
I can also just touch a file by hand

[ggwpez]

noobs question, would that bot call actually create a diff, since this PR has no changes?

Yes it should. And yes; modifying by hand is also possible, but I am lazy and then you would have to revert it 😛
This way we can see that it works end-to-end.

[command-bot]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2542934 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2542934/artifacts/download.

[ggwpez]

This is how it looks now, seems fine 👍

[athei]

and they don't affect the PR diff numbers, (so people are not scared by a big number when they review your PR)

This part seems to be wrong :( Look at the diff stats of this PR. It includes the generated file. Other PRs which include this change also have scary diff stats: #13312

The description of the feature also never mentions that it will be ignored in PR diff stats. Only in the PRs repository's language statistics. So it does seem to be intentional. I wish there were a way to hide it from PR diff stats, though.

[pgherveou]

and they don't affect the PR diff numbers, (so people are not scared by a big number when they review your PR)

This part seems to be wrong :( Look at the diff stats of this PR. It includes the generated file. Other PRs which include this change also have scary diff stats: #13312

The description of the feature also never mentions that it will be ignored in PR diff stats. Only in the PRs repository's language statistics. So it does seem to be intentional. I wish there were a way to hide it from PR diff stats, though.

yep saw that as well, this is not that useful after all...