This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Hotfix NIS benchmark #13651
Merged
Hotfix NIS benchmark #13651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
gavofyork
approved these changes
Mar 20, 2023
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
* Hotfix NIS rounding error Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Also fix communal Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Hotfix NIS rounding error Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Also fix communal Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/polkadot#6780 is currently stuck because of a rounding error in the NIS pallet /
sp-arithmetic.This MR hot-fixes it by increasing the pot amount to make the benchmark pass. Obviously not a proper fix, but something to unblock the CI for everyone else.