Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove unused light-client leftover #13687

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Mar 23, 2023

Remove some leftover light-client code.

SyncingEngine instantiated here:

Roles::from(&config.role),

Can not be light client :
impl<'a> From<&'a Role> for Roles {
fn from(roles: &'a Role) -> Self {
match roles {
Role::Full => Self::FULL,
Role::Authority => Self::AUTHORITY,
}
}
}

@skunert skunert added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”. labels Mar 23, 2023
@skunert skunert requested review from altonen and a team March 23, 2023 08:20
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed T0-node This PR/Issue is related to the topic “node”. A0-please_review Pull request needs code review. labels Mar 23, 2023
@skunert skunert merged commit 1184143 into paritytech:master Mar 23, 2023
@skunert skunert deleted the skunert/light-client-leftover branch March 23, 2023 10:35
breathx pushed a commit to gear-tech/substrate that referenced this pull request Apr 22, 2023
* Remove unused light-client leftover

* Remove more unused code
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Remove unused light-client leftover

* Remove more unused code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants