Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adds integration test for slashed/chilled validator with subsequent validation intention #13717

Merged
merged 9 commits into from
May 15, 2023

Conversation

gpestana
Copy link
Contributor

Adds integration test for case mentioned in paritytech/polkadot-sdk#420

@gpestana gpestana added A0-please_review Pull request needs code review. Z0-trivial Writing the issue is of the same difficulty as patching the code. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 27, 2023
@gpestana gpestana requested a review from a team March 27, 2023 06:49
@gpestana gpestana self-assigned this Mar 27, 2023
@gpestana
Copy link
Contributor Author

gpestana commented May 1, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

assert_eq!(
staking_events(),
[
Event::Chilled { stash: 11 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we chill under all conditions? I didn't know this off the top of my head.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment about the CI was concerning.

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 7f71737

@gpestana
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 2153367 into master May 15, 2023
@paritytech-processbot paritytech-processbot bot deleted the gpestana/integration_test_chilled branch May 15, 2023 12:04
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…alidation intention (paritytech#13717)

* Adds integration test for slashed/chilled validator with subsequent validation intention

* Removes unecessary comment

* Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Addresses PR review comments

* Fixes after conflict resolved

---------

Co-authored-by: parity-processbot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. Z0-trivial Writing the issue is of the same difficulty as patching the code.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants