Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Generic keystore internals #13749

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Generic keystore internals #13749

merged 3 commits into from
Mar 29, 2023

Conversation

davxy
Copy link
Member

@davxy davxy commented Mar 29, 2023 •
edited
Loading

Remove some code duplication

@davxy davxy self-assigned this Mar 29, 2023
@davxy davxy added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 29, 2023
@davxy davxy requested a review from a team March 29, 2023 15:07
@davxy davxy requested a review from a team March 29, 2023 19:51
@michalkucharczyk michalkucharczyk requested a review from a team March 29, 2023 20:54
@davxy davxy merged commit 9c92e49 into master Mar 29, 2023
@davxy davxy deleted the davxy-generic-keystore-internals branch March 29, 2023 23:22
pgherveou pushed a commit that referenced this pull request Apr 4, 2023
@davxy @pgherveou
Generic keystore internals (#13749)
32b62b1 
* Generic testing keystore internals

* Generic local keystore internals

* Restore deleted comment
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@davxy @gpestana
Generic keystore internals (#13749)
57dddd2 
* Generic testing keystore internals

* Generic local keystore internals

* Restore deleted comment
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@davxy @nathanwhit
Generic keystore internals (paritytech#13749)
79a90e2 
* Generic testing keystore internals

* Generic local keystore internals

* Restore deleted comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@bkchr bkchr bkchr approved these changes

Assignees

@davxy davxy

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davxy @michalkucharczyk @bkchr