This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Fix] Bump tuple element number in frame-support. #13760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .
ruseinov
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Mar 29, 2023
sam0x17
approved these changes
Mar 29, 2023
bkchr
approved these changes
Mar 29, 2023
ggwpez
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also do it in the template node.
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 94e97f0 |
bot rebase |
Rebased |
bot merge |
Waiting for commit status. |
No need it seems, there are only a few pallets attached. Now that we have a decent error - it should be more straightforward for others. |
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 . Co-authored-by: parity-processbot <>
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 . Co-authored-by: parity-processbot <>
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1 |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 . Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently at the tuple element limit, when we reach that - the runtime compilation fails with a cryptic error. This PR bumps the tuple element number by 50% to ensure nobody hits this.
Details could be found here: https://substrate.stackexchange.com/questions/7212