Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Insert claim_commission weight #13774

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Insert claim_commission weight #13774

merged 1 commit into from
Apr 1, 2023

Conversation

rossbulat
Copy link

@rossbulat rossbulat commented Mar 31, 2023 •
edited
Loading

claim_commission did not have its calculated weight associated with the call. This PR fixes this.

@rossbulat rossbulat requested a review from a team March 31, 2023 03:00
@rossbulat rossbulat added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 31, 2023
kianenigma
kianenigma approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good harmless incident to push @paritytech/staking-core myself included to up the review quality further 🆙 ⬆️

ggwpez
ggwpez approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@ggwpez
Copy link
Member

ggwpez commented Apr 1, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9b94d38 into master Apr 1, 2023
@paritytech-processbot paritytech-processbot bot deleted the rb-add-claim-commission-weight branch April 1, 2023 17:19
@ggwpez
Copy link
Member

ggwpez commented Apr 1, 2023 •
edited
Loading

We could forbid hardcoded constant as weignts in non dev-mode pallets. @kianenigma
PS: #13798

@ggwpez ggwpez mentioned this pull request Apr 1, 2023
Merged
1 task
pgherveou pushed a commit that referenced this pull request Apr 4, 2023
@pgherveou
add claim_commission weight (#13774)
e5f6b30
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@gpestana
add claim_commission weight (#13774)
19fe15a
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1

@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@nathanwhit
add claim_commission weight (paritytech#13774)
61aade6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@kianenigma kianenigma kianenigma approved these changes

@gpestana gpestana Awaiting requested review from gpestana

@Ank4n Ank4n Awaiting requested review from Ank4n

@KiChjang KiChjang Awaiting requested review from KiChjang

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rossbulat @ggwpez @Polkadot-Forum @kianenigma