Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: make test work with debugger #13776

Merged
merged 8 commits into from
Mar 31, 2023

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Mar 31, 2023

When debugging tests, the CARGO_* environment variables are not set, and thus the relative path fails to resolve.
using a path relative to PWD should make things work

@pgherveou pgherveou requested a review from athei as a code owner March 31, 2023 07:51
@pgherveou pgherveou added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 31, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2624095

frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pgherveou
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 390dbbd

@athei
Copy link
Member

athei commented Mar 31, 2023

Failure unrelated to code change.

@athei athei merged commit 75dee3c into master Mar 31, 2023
@athei athei deleted the pg/contracts-make-test-work-with-debugger branch March 31, 2023 17:44
pgherveou added a commit that referenced this pull request Apr 4, 2023
* contracts: make test work with debugger

* fix path

* PR review

* Add comment

* space

* Update frame/contracts/src/tests.rs

* lint

* spelling
gpestana pushed a commit that referenced this pull request Apr 23, 2023
* contracts: make test work with debugger

* fix path

* PR review

* Add comment

* space

* Update frame/contracts/src/tests.rs

* lint

* spelling
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* contracts: make test work with debugger

* fix path

* PR review

* Add comment

* space

* Update frame/contracts/src/tests.rs

* lint

* spelling
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants