Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils #13794

liamaharon · 2023-03-31T18:21:13Z

Fixes folllow-chain bug (closes try-runtime follow-chain seems broken #13696)
Refactors existing node CLI test utility functions so that they may be used by other packages
Adds a follow-chain test (related try-runtime-cli docs and tests #13796)
Adds test validating that pre_upgrade and post_upgrade hooks are executed correctly for tuple migrations (related: try-runtime pre-post hooks not executed if defined within the pallet #13681)

…x-try-runtime-follow-chain

frame/support/src/traits/hooks.rs

kianenigma

New tests to prevent this happening again?

liamaharon · 2023-04-04T16:32:41Z

Hey @kianenigma, I've added a test for follow-chain.

The test

Spins up a --dev node child process and waits for it to validate its first block
Spins up a try-runtime follow-chain child process and waits for it to successfully follow at least 3 blocks

Misc extra notes/questions about the changes:

I moved cli testing utils from bin/node/cli/tests/common.rs to test-utils/cli/src/lib.rs so they could be shared between node CLI tests and try-runtime CLI tests, and added a new util in there.
The existing Command::new(cargo_bin("substrate")) pattern used to spawn a substrate child process seems to use target/debug/substrate. This means that a test could be broken by some changes, but the tests would pass if the project was not re-built. This feels a bit off, I'm wondering if there could be a better approach, to make sure the latest code is always used? edit: found a solution to this

…x-try-runtime-follow-chain

kianenigma · 2023-04-06T07:24:09Z

utils/frame/try-runtime/cli/tests/follow_chain.rs

+	use tokio::process::{Child, Command};
+
+	#[tokio::test]
+	async fn follow_chain_works() {


now that we have the infra, should we make tests for all commands? can be an issue that you either do yourself, or mentor.

Yes, I think we should have tests for subcommands too; otherwise they'll just accidentally break sooner or later.

Absolutely, it's tracked in this issue: #13796. I wanted to test just one command and get the approach reviewed before adding tests for the rest of them.

There're issues reported with some of the other try-runtime commands that I'm close to getting started on, I'll utilise this test infra while debugging those and leave the tests in the fix PR.

kianenigma

LGTM, but would be good if someone from @paritytech/sdk-node also takes a look 👍

test-utils/cli/src/lib.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

…test utils (paritytech#13794) * new test for try-runtime tuple stuff * fix * remove development comment * formatting * remove todo comment * follow-chain working test * refactor common cli testing utils * fix comment * revert Cargo.lock changes * update Cargo.lock * improve doc comment * fix error typo * update Cargo.lock * feature gate try-runtime test * build_substrate cli test util * feature gate follow_chain tests * move fn start_node to test-utils * improve test pkg name * use tokio Child and Command * remove redundant import * fix ci * fix ci * don't leave hanging processes * improved child process cleanup * use existing KillChildOnDrop * remove redundant comment * Update test-utils/cli/src/lib.rs Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Koute <koute@users.noreply.github.com>

…test utils (#13794) * new test for try-runtime tuple stuff * fix * remove development comment * formatting * remove todo comment * follow-chain working test * refactor common cli testing utils * fix comment * revert Cargo.lock changes * update Cargo.lock * improve doc comment * fix error typo * update Cargo.lock * feature gate try-runtime test * build_substrate cli test util * feature gate follow_chain tests * move fn start_node to test-utils * improve test pkg name * use tokio Child and Command * remove redundant import * fix ci * fix ci * don't leave hanging processes * improved child process cleanup * use existing KillChildOnDrop * remove redundant comment * Update test-utils/cli/src/lib.rs Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Koute <koute@users.noreply.github.com>

Polkadot-Forum · 2023-05-02T08:44:13Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1

…test utils (paritytech#13794) * new test for try-runtime tuple stuff * fix * remove development comment * formatting * remove todo comment * follow-chain working test * refactor common cli testing utils * fix comment * revert Cargo.lock changes * update Cargo.lock * improve doc comment * fix error typo * update Cargo.lock * feature gate try-runtime test * build_substrate cli test util * feature gate follow_chain tests * move fn start_node to test-utils * improve test pkg name * use tokio Child and Command * remove redundant import * fix ci * fix ci * don't leave hanging processes * improved child process cleanup * use existing KillChildOnDrop * remove redundant comment * Update test-utils/cli/src/lib.rs Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Koute <koute@users.noreply.github.com>

kianenigma and others added 5 commits March 31, 2023 16:08

new test for try-runtime tuple stuff

cf0874d

fix

b62c68c

Merge branch 'master' of github.com:paritytech/substrate into liam-fi…

7ccae6c

…x-try-runtime-follow-chain

remove development comment

d1ac703

formatting

e826168

liamaharon added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes labels Mar 31, 2023

liamaharon requested a review from kianenigma March 31, 2023 18:21

liamaharon added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 31, 2023

kianenigma reviewed Mar 31, 2023

View reviewed changes

frame/support/src/traits/hooks.rs Outdated Show resolved Hide resolved

kianenigma reviewed Mar 31, 2023

View reviewed changes

liamaharon mentioned this pull request Apr 1, 2023

parameter_types! helper functions should be uniform across modes #13795

Closed

remove todo comment

cfd0dd7

liamaharon added the T0-node This PR/Issue is related to the topic “node”. label Apr 1, 2023

liamaharon marked this pull request as draft April 1, 2023 08:30

liamaharon mentioned this pull request Apr 4, 2023

try-runtime-cli docs and tests #13796

Closed

6 tasks

liamaharon added 3 commits April 4, 2023 19:17

follow-chain working test

d5d58bc

refactor common cli testing utils

8094ba8

fix comment

b2ad590

liamaharon requested a review from kianenigma April 4, 2023 16:32

liamaharon marked this pull request as ready for review April 4, 2023 16:34

liamaharon added 6 commits April 4, 2023 20:39

revert Cargo.lock changes

f644dfa

update Cargo.lock

b9a6eba

improve doc comment

90f135e

fix error typo

00aa83b

Merge branch 'master' of github.com:paritytech/substrate into liam-fi…

cd56330

…x-try-runtime-follow-chain

update Cargo.lock

0f79142

liamaharon marked this pull request as draft April 5, 2023 06:40

liamaharon added 3 commits April 5, 2023 14:49

move fn start_node to test-utils

3ca75d3

improve test pkg name

2a6d812

use tokio Child and Command

7b3ca6f

liamaharon marked this pull request as ready for review April 5, 2023 10:59

liamaharon changed the title ~~Fix try-runtime follow-chain, add pre/post runtime upgrade tuple test~~ Fix try-runtime follow-chain, try-runtime upgrade tuple tests, cli test utils Apr 5, 2023

liamaharon added 9 commits April 5, 2023 15:46

Merge branch 'master' of github.com:paritytech/substrate into liam-fi…

a1907b3

…x-try-runtime-follow-chain

remove redundant import

391b741

fix ci

99e23ae

Merge branch 'master' of github.com:paritytech/substrate into liam-fi…

b122fe6

…x-try-runtime-follow-chain

fix ci

28dab86

don't leave hanging processes

ffeb781

improved child process cleanup

99c62a7

use existing KillChildOnDrop

8c351c2

remove redundant comment

10a7b9e

kianenigma reviewed Apr 6, 2023

View reviewed changes

kianenigma approved these changes Apr 6, 2023

View reviewed changes

koute approved these changes Apr 6, 2023

View reviewed changes

test-utils/cli/src/lib.rs Outdated Show resolved Hide resolved

Update test-utils/cli/src/lib.rs

a01da35

Co-authored-by: Koute <koute@users.noreply.github.com>

liamaharon merged commit a1d3d50 into master Apr 6, 2023

liamaharon deleted the liam-fix-try-runtime-follow-chain branch April 6, 2023 09:49

kianenigma mentioned this pull request Apr 6, 2023

try-runtime: execute a range of past blocks #13840

Closed

pmikolajczyk41 mentioned this pull request Jun 12, 2023

A0-2672: Fix try-runtime/follow-chain Cardinal-Cryptography/substrate#39

Merged

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

liamaharon mentioned this pull request Aug 14, 2023

Execute a range of past blocks paritytech/try-runtime-cli#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils #13794

Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils #13794

liamaharon commented Mar 31, 2023 •

edited

Loading

kianenigma left a comment

liamaharon commented Apr 4, 2023 •

edited

Loading

kianenigma Apr 6, 2023

koute Apr 6, 2023

liamaharon Apr 6, 2023

kianenigma left a comment

Polkadot-Forum commented May 2, 2023

Fix try-runtime follow-chain, try-runtime upgrade tuple tests, cli test utils #13794

Fix try-runtime follow-chain, try-runtime upgrade tuple tests, cli test utils #13794

Conversation

liamaharon commented Mar 31, 2023 • edited Loading

kianenigma left a comment

Choose a reason for hiding this comment

liamaharon commented Apr 4, 2023 • edited Loading

kianenigma Apr 6, 2023

Choose a reason for hiding this comment

koute Apr 6, 2023

Choose a reason for hiding this comment

liamaharon Apr 6, 2023

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

Polkadot-Forum commented May 2, 2023

Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils #13794

Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils #13794

liamaharon commented Mar 31, 2023 •

edited

Loading

liamaharon commented Apr 4, 2023 •

edited

Loading