Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Updates Benchmark macro parsing to use Generic Argument #13919

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Updates Benchmark macro parsing to use Generic Argument #13919

merged 6 commits into from
Apr 14, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Apr 14, 2023

Uses Oliver's suggestion as discussed in #13897

Will update #13845 once this is merged.

ggwpez and others added 2 commits April 13, 2023 18:14
@ggwpez
WIP
6a24c0a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@codekitz
Removes POC code
6fba67e
@gupnik gupnik added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 14, 2023
@gupnik gupnik requested review from sam0x17 and ggwpez April 14, 2023 03:48
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2683152

sam0x17
sam0x17 reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me now that I know you can do this with the {} generic syntax -- let's get some tests

ggwpez
ggwpez approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% that error message

@gupnik
Copy link
Contributor Author

gupnik commented Apr 14, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 14, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686470 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 24-d37cd50b-126a-4648-8603-434efa495f95 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 14, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686470 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686470/artifacts/download.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 14, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 14, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686534 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 25-38099a0a-ea10-4bbd-be74-1427200a55f8 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 14, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686534 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2686534/artifacts/download.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 14, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@gupnik gupnik merged commit 3f8dc9e into master Apr 14, 2023
@gupnik gupnik deleted the oty-demo-bench-syntax branch April 14, 2023 17:24
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@codekitz @ggwpez @nathanwhit
Updates Benchmark macro parsing to use Generic Argument (paritytech#1…
5a0ab09 
…3919)

* WIP

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Removes POC code

* Adds assertion and UT

* adds runtime error

* removes const_assert

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gupnik @paritytech-cicd-pr @sam0x17 @ggwpez @codekitz