Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

imp function comparison #13928

Merged
merged 1 commit into from
Apr 17, 2023
Merged

imp function comparison #13928

merged 1 commit into from
Apr 17, 2023

Conversation

itmilos
Copy link
Contributor

@itmilos itmilos commented Apr 16, 2023

  • **Description:
    In the refactored code, I replaced the series of if statements with a single match expression, which is more concise and easier to read.

  • Labels: You labeled the PR appropriately if you have permissions to do so:

    • A* for PR status (one required)

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Apr 16, 2023

User @itmilos, please sign the CLA here.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 16, 2023
@bkchr bkchr requested a review from kianenigma April 16, 2023 21:01
@ggwpez
Copy link
Member

ggwpez commented Apr 17, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 15bb9c6 into paritytech:master Apr 17, 2023
@itmilos itmilos deleted the improve_display_if_to_match branch April 17, 2023 22:45
@itmilos itmilos restored the improve_display_if_to_match branch April 17, 2023 22:45
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@itmilos @nathanwhit
imp function comparison (paritytech#13928)
00afc3c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itmilos @ggwpez @bkchr