This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
replace unused cargo-deny check with a new cargo-deny-licenses job #13956
+73
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been broken and disabled for quite a while, and per internal discussion there doesn't seem to be any interest in fixing it and actually using the job output for anything.
altaua
added
A2-insubstantial
It'll run on all PRs and fail if external dependencies with unsuitable licenses are detected.
alvicsam
approved these changes
Apr 20, 2023
sergejparity
approved these changes
Apr 20, 2023
Closed
|
Substrate current licensing policy is: I've added a crate under |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…aritytech#13956) * ci: remove the cargo-deny job It's been broken and disabled for quite a while, and per internal discussion there doesn't seem to be any interest in fixing it and actually using the job output for anything. * ci: add new cargo-deny-licenses job It'll run on all PRs and fail if external dependencies with unsuitable licenses are detected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
cargo-denyjob had been broken and disabled for a long time, and per internal discussion there doesn't seem to be any interest in fixing it and actually using the job output for anything.The new job will run on all PRs and only use
cargo deny's facility for detecting dependencies with problematic licenses, as requested in https://github.com/paritytech/ci_cd/issues/777.