Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Don't run check-crates-publishing job on prs #14064

Merged
merged 2 commits into from
May 3, 2023

Conversation

altaua
Copy link
Contributor

@altaua altaua commented May 2, 2023

Fixes a previous attempt in #14044.

Mira Ressel added 2 commits May 2, 2023 19:29
This job was errorneously deleted in lieu of the
`check-crates-publishing` job.

This reverts commit de80d01.
Originally attempted in #14044. It's been broken for a while and we're
not sure yet how to move forward in the longer term.
@altaua altaua added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 2, 2023
@altaua altaua requested a review from a team as a code owner May 2, 2023 17:38
@altaua altaua self-assigned this May 2, 2023
@paritytech-ci paritytech-ci requested a review from a team May 2, 2023 17:42
@bkchr
Copy link
Member

bkchr commented May 3, 2023

What does this fixes? This job should stay disabled and not being run somewhere else.

@altaua altaua merged commit f78bccc into master May 3, 2023
@altaua altaua deleted the mira/check-crate-publishing branch May 3, 2023 10:47
@altaua
Copy link
Contributor Author

altaua commented May 3, 2023

What does this fixes? This job should stay disabled and not being run somewhere else.

The infrastructure for running it in a nightly pipeline still exists (though we've disabled the pipeline in question for now); if there is no interest in developing it further, we'll drop it from the pipeline specs eventually.

gpestana pushed a commit that referenced this pull request May 4, 2023
* Restore `check-crates-publishing-pipeline` job

This job was errorneously deleted in lieu of the
`check-crates-publishing` job.

This reverts commit de80d01.

* Don't run `check-crate-publishing` job on prs.

Originally attempted in #14044. It's been broken for a while and we're
not sure yet how to move forward in the longer term.
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Restore `check-crates-publishing-pipeline` job

This job was errorneously deleted in lieu of the
`check-crates-publishing` job.

This reverts commit de80d01.

* Don't run `check-crate-publishing` job on prs.

Originally attempted in paritytech#14044. It's been broken for a while and we're
not sure yet how to move forward in the longer term.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants