This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Only calculate tree route during finalization when there are multiple leaves #14067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
A0-please_review
bkchr
approved these changes
May 3, 2023
altonen
approved these changes
May 3, 2023
lexnv
approved these changes
May 3, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
False alert, I was running off a db which was close to the tip of the chain, this PR has indeed the desired effect. |
|
bot merge |
|
Waiting for commit status. |
|
Thank you for the work! |
chevdor
pushed a commit
that referenced
this pull request
May 3, 2023
… leaves (#14067) * Only calculate tree route when there are multiple leaves * Update client/service/src/client/client.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de>
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
… leaves (#14067) * Only calculate tree route when there are multiple leaves * Update client/service/src/client/client.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de>
crystalin
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
May 5, 2023
… leaves (paritytech#14067) * Only calculate tree route when there are multiple leaves * Update client/service/src/client/client.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de>
Closed
2 tasks
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
… leaves (paritytech#14067) * Only calculate tree route when there are multiple leaves * Update client/service/src/client/client.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de>
vanderian
pushed a commit
to gasp-xyz/substrate
that referenced
this pull request
Jul 26, 2023
… leaves (paritytech#14067) (paritytech#14069) * Only calculate tree route when there are multiple leaves * Update client/service/src/client/client.rs --------- Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Bastian Köcher <git@kchr.de>
Open
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of these tree routes is very expensive. When the finalized block is very far from the best block, it can take multiple seconds to calculate this tree route, blocking the import lock.
If there is only one leave, we can skip this calculation since the best block is guaranteed to be a descendant of the new finalized one.
Closes paritytech/cumulus#2494, paritytech/polkadot-sdk#13,
Could impact the parachain part of paritytech/polkadot-sdk#11
Edit: Do not close the above issues for now, freshly syncing node still has issues.