Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CI: cargo-check-benches: don't merge in master if base ref isn't master #14071

Merged
1 commit merged into from
May 4, 2023

Conversation

rcny
Copy link
Contributor

@rcny rcny commented May 3, 2023

Fixes CI failures like that (from #14070).

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 3, 2023
@rcny rcny requested a review from a team as a code owner May 3, 2023 18:44
@paritytech-ci paritytech-ci requested a review from a team May 3, 2023 19:17
@altaua
Copy link
Contributor

altaua commented May 3, 2023

lgtm; alternatively, if we want the merge to happen even in these cases, we could just fetch from github instead of gitlab.

@ghost ghost merged commit 82f783d into master May 4, 2023
@ghost ghost deleted the vi/check-benches-premerge-fix branch May 4, 2023 10:32
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants