This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juangirini
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 4, 2023
ggwpez
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ggwpez
approved these changes
May 4, 2023
ggwpez
approved these changes
May 4, 2023
Hm i have on idea how to approve on behalf of the team or not 😆 |
athei
approved these changes
May 4, 2023
kianenigma
reviewed
May 5, 2023
kianenigma
approved these changes
May 5, 2023
Cool, so this is useful if @paritytech/frame-coders actually look at their notifications though, which I hope they do 😜 |
I wonder if some pallets that are handled by @joepetrowski and team can also have dedicated owners; eg uniques and NFT to @jsidorenko? |
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
bot merge |
Waiting for commit status. |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* update codeowners file * reorganise codeowners file * Update docs/CODEOWNERS Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * add nfts and uniques ownership * sort codeowners alphabetically --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CODEOWNERS file
Fixes #14054