Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve try-runtime::on_runtime_upgrade and fix some storage version issues #14083

Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 5, 2023

We now run all try_on_runtime_upgrade and collect the errors, instead of bailing on the first error. This makes it easier to see directly all the things that are failing instead of fixing one, recompiling and then checking the next one.

Then this pr also sets the correct storage version for pallet-bounties that was already correctly set in the storage with the appropriate migration.

…n issues

We now run all `try_on_runtime_upgrade` and collect the errors, instead of bailing on the first
error. This makes it easier to see directly all the things that are failing instead of fixing one,
recompiling and then checking the next one.

Then this pr also sets the correct storage version for `pallet-bounties` that was already correctly
set in the storage with the appropriate migration.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 5, 2023
@bkchr bkchr requested a review from a team May 5, 2023 15:24
@ggwpez
Copy link
Member

ggwpez commented May 5, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9957da3 into master May 5, 2023
@paritytech-processbot paritytech-processbot bot deleted the bkchr-fix-some-storage-version-issues branch May 5, 2023 17:25
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…n issues (paritytech#14083)

We now run all `try_on_runtime_upgrade` and collect the errors, instead of bailing on the first
error. This makes it easier to see directly all the things that are failing instead of fixing one,
recompiling and then checking the next one.

Then this pr also sets the correct storage version for `pallet-bounties` that was already correctly
set in the storage with the appropriate migration.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants