Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove #[pallet::generate_storage_info] from docs #14116

Merged
merged 2 commits into from
May 10, 2023
Merged

Remove #[pallet::generate_storage_info] from docs #14116

merged 2 commits into from
May 10, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented May 10, 2023

Closes #14089

#[pallet::generate_storage_info] is not valid, and was probably added to the docs in error.
It is only valid in the old decl_* pallet syntax.

@ggwpez
Fix docs
4df48e1 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add UI test
e26cb0f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 10, 2023
@ggwpez ggwpez self-assigned this May 10, 2023
@ggwpez ggwpez requested review from a team and kianenigma May 10, 2023 10:30
@KiChjang
Copy link
Contributor

KiChjang commented May 10, 2023 •
edited
Loading

Wait no, it was valid when we didn't MEL bound our storage types, and can't be used in the old decl_* syntax. Am I remembering correctly that we now ensure that every storage item is MEL bound?

@ggwpez
Copy link
Member Author

ggwpez commented May 10, 2023

Wait no, it was valid when we didn't MEL bound our storage types, and can't be used in the old decl_* syntax.

Ah yes, could be. But it also works in the old syntax

substrate/frame/support/procedural/src/lib.rs

Line 294 in 2a148e3

/// decl_storage! { generate_storage_info

Am I remembering correctly that we now ensure that every storage item is MEL bound?

Yes, otherwise without_storage_info or selective unbounded are needed.

@ggwpez
Copy link
Member Author

ggwpez commented May 10, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 49154cc into master May 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-fix-docs branch May 10, 2023 20:29
niklasad1 pushed a commit that referenced this pull request May 17, 2023
@ggwpez @niklasad1
Remove #[pallet::generate_storage_info] from docs (#14116)
008cef2 
* Fix docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add UI test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @nathanwhit
Remove #[pallet::generate_storage_info] from docs (paritytech#14116)
67d3978 
* Fix docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add UI test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gpestana gpestana gpestana approved these changes

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate #[pallet::generate_storage_info]
3 participants
@ggwpez @KiChjang @gpestana