Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Assets: impl ContainsPair for asset and account IDs #14119

Merged
merged 2 commits into from
May 11, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented May 10, 2023

Implementation of ContainsPair trait for Assets pallet, to check if an account with the given asset ID and account address exists.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 10, 2023
@muharem muharem marked this pull request as ready for review May 10, 2023 15:16
@muharem muharem requested review from a team, ggwpez, joepetrowski and bkchr May 10, 2023 15:16
@KiChjang
Copy link
Contributor

Do you intend to use the pallet as a config item to IsReserve or IsTeleporter in the XCM config?

@muharem
Copy link
Contributor Author

muharem commented May 11, 2023

Do you intend to use the pallet as a config item to IsReserve or IsTeleporter in the XCM config?

no, it will be used in asset-conversion pallet to check if the system account already exist or should be created.

@muharem
Copy link
Contributor Author

muharem commented May 11, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c09f0bc into master May 11, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-asset-contains-account branch May 11, 2023 15:56
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Assets impl ContainsPair for asset and account IDs

* clap version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants