Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump Cargo.lock #14121

Merged
merged 4 commits into from
May 10, 2023
Merged

Bump Cargo.lock #14121

merged 4 commits into from
May 10, 2023

Conversation

rcny
Copy link
Contributor

@rcny rcny commented May 10, 2023

...to keep up with the cargo update changes.

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 10, 2023
ggwpez
ggwpez suggested changes May 10, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry saw it wrong. cargo update should not be needed, let me try.

ggwpez added 3 commits May 10, 2023 23:34
@ggwpez
Use master Cargo.lock
26519d0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into vi/cargo-update
8339f5a
@ggwpez
Update Cargo.lock
fae3974 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label May 10, 2023
@ggwpez ggwpez requested a review from a team May 10, 2023 21:40
@ggwpez
Copy link
Member

ggwpez commented May 10, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit aee8f76 into master May 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the vi/cargo-update branch May 10, 2023 22:35
@bkchr
Copy link
Member

bkchr commented May 10, 2023

What was the point of this pr?

@koute
Copy link
Contributor

koute commented May 11, 2023

What was the point of this pr?

Someone accidentally didn't fully commit the Cargo.lock with their PR, so for everyone building the current master even with no changes they had cargo always update the Cargo.lock with the same patch as the one in this PR.

niklasad1 pushed a commit that referenced this pull request May 17, 2023
@rcny @ggwpez @niklasad1
Bump Cargo.lock (#14121)
e9057bc 
* Bump `Cargo.lock`

* Use master Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@rcny @ggwpez @nathanwhit
Bump Cargo.lock (paritytech#14121)
029323e 
* Bump `Cargo.lock`

* Use master Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Cargo.lock

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcny @ggwpez @bkchr @koute @ordian