Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

remote-externalities: retry for get_keys #14167

Merged
merged 4 commits into from
May 19, 2023
Merged

remote-externalities: retry for get_keys #14167

merged 4 commits into from
May 19, 2023

Conversation

liamaharon
Copy link
Contributor

Closes #14129

Retries get key requests once every 5s up to 12 times (60s total).

Logs demonstrating behavior when I took my node down while keys were being scraped and booted it back up ~30 seconds later:

Screenshot 2023-05-17 at 19 32 00

I don't believe we'll need this retry logic for the other requests that're not made in rapid succession, but we should keep an eye on it.

@liamaharon liamaharon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 17, 2023
@liamaharon liamaharon requested review from ggwpez and a team May 17, 2023 15:39
ggwpez
ggwpez approved these changes May 17, 2023
View reviewed changes
utils/frame/remote-externalities/src/lib.rs Outdated Show resolved Hide resolved
@ggwpez ggwpez requested a review from niklasad1 May 17, 2023 16:32
niklasad1
niklasad1 approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, it just that hyper client has its background task if something goes wrong there this won't make any progress with your fix.

Ideally, the client should "reconnect" in some scenarios but as that is involved to fix.

@liamaharon
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 2c3b923 into master May 19, 2023
@paritytech-processbot paritytech-processbot bot deleted the liam-remote-ext-get-keys-retry branch May 19, 2023 19:26
gpestana pushed a commit that referenced this pull request May 27, 2023
@liamaharon @gpestana
remote-externalities: retry for get_keys (#14167)
4ae533d 
* retry get keys request

* remove redundant clone

* remove redundant at
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@liamaharon @nathanwhit
remote-externalities: retry for get_keys (paritytech#14167)
6291861 
* retry get keys request

* remove redundant clone

* remove redundant at
@dmitrylavrenov dmitrylavrenov mentioned this pull request Oct 29, 2024
Open
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@ggwpez ggwpez ggwpez approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try-runtime-cli retry for get_keys
4 participants
@liamaharon @sam0x17 @ggwpez @niklasad1