Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sc-client-db: add test for reverting finalized blocks #14205

Merged
merged 1 commit into from
May 24, 2023
Merged

sc-client-db: add test for reverting finalized blocks #14205

merged 1 commit into from
May 24, 2023

Conversation

andresilva
Copy link
Contributor

Wrote this test to debug #14194.

@andresilva andresilva added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 23, 2023
@andresilva andresilva requested a review from a team May 23, 2023 16:11
melekes
melekes approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalkucharczyk michalkucharczyk requested a review from a team May 24, 2023 07:29
@andresilva
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bf92638 into master May 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the andre/revert-finalized-backend-test branch May 24, 2023 09:09
gpestana pushed a commit that referenced this pull request May 27, 2023
@andresilva @gpestana
sc-client-db: add test for reverting finalized blocks (#14205)
da4d931
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
@andresilva @Ank4n
sc-client-db: add test for reverting finalized blocks (#14205)
3007a0a
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@andresilva @nathanwhit
sc-client-db: add test for reverting finalized blocks (paritytech#14205)
0737c5a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andresilva @melekes @michalkucharczyk @bkchr