This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bump sp-crates from latest crates.io version and release #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
A0-please_review
lexnv
requested review from
athei,
acatangiu,
sorpaas,
andresilva and
jsidorenko
as code owners
This was referenced May 30, 2023
niklasad1
approved these changes
May 30, 2023
tadeohepperle
approved these changes
May 30, 2023
jsdw
approved these changes
May 30, 2023
…s_two Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
sam0x17
approved these changes
May 31, 2023
|
bot merge |
This was referenced Jun 1, 2023
|
@lexnv maybe the same modifications are required for some frame pallets? Question. Why these major numbers are incremented so often when publishing? Shouldn't we increment minors? |
|
@davxy there was this script running that was publishing to master every week, which should be the reason for this high major number. The script is not running anymore and we will replace it with a new system |
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the SP-crates to the latest version from crates.io + a version bump for release.
This is a follow-up to: #14237.
It seems that some sp-crates where published on crates.io previously without doing a PR in substrate.
This behavior led the subpub tool to increment the crates versions from the local Cargo.toml, instead of inspecting crates.io.
Related subpub PR: paritytech/subpub#12
Similarly, we need to publish the following crates:
Versions bumped to achieve this:
cumulus companion: paritytech/cumulus#2655
polkadot companion: paritytech/polkadot#7307
// @paritytech/subxt-team