This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Improves the EPM/Staking e2e test setup #14292
Merged
paritytech-processbot
merged 7 commits into
master
from
gpestana/13589-e2e_tests_staking
Jul 18, 2023
Merged
Improves the EPM/Staking e2e test setup #14292
paritytech-processbot
merged 7 commits into
master
from
gpestana/13589-e2e_tests_staking
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
A0-please_review
Pull request needs code review.
I5-tests
Tests need fixing, improving or augmenting.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T1-runtime
This PR/Issue is related to the topic “runtime”.
labels
Jun 2, 2023
gpestana
changed the title
Gpestana/13589 e2e tests staking
Improves the EPM/Staking e2e test setup
Jun 2, 2023
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Ank4n
reviewed
Jul 4, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
Outdated
Show resolved
Hide resolved
Ank4n
reviewed
Jul 4, 2023
Ank4n
reviewed
Jul 4, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
Outdated
Show resolved
Hide resolved
Ank4n
reviewed
Jul 4, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
Outdated
Show resolved
Hide resolved
Ank4n
reviewed
Jul 4, 2023
Ank4n
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, but overall LGTM!
kianenigma
reviewed
Jul 10, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Jul 10, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
approved these changes
Jul 10, 2023
can be merged once conflict is resolved. |
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 0d9d40d |
bot merge |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Adds onchainify to e2e tests; Adds try-runtime checks at the end of the tests * Refactors OCW to be more realistic and to submit solutions during unsigned phase * Uses config palllet Default impl in mock * Improves OCW progression vode * simplified OCW tests
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* Adds onchainify to e2e tests; Adds try-runtime checks at the end of the tests * Refactors OCW to be more realistic and to submit solutions during unsigned phase * Uses config palllet Default impl in mock * Improves OCW progression vode * simplified OCW tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
I5-tests
Tests need fixing, improving or augmenting.
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the current staking/EPM e2e test setup, namely:
try-state
at the end of the tests for relevant palletsderive_impl
Helps with paritytech/polkadot-sdk#423