pallet-glutton: over-unity consumption

[ggwpez]

The PoV benchmarking is over-estimating the actual proof size of storage reads.

Now after testing the pallet on Versi, we saw that it consumed 19% (compressed) PoV when requested to use 50%.
To make it possible to eventually consume the full 100%; over-unity values are needed for the proof and computation weight.

This is done by changing Perbill to FixedU64 with a range of [0, 10] that will be interpreted as [0, 1000]%.
As next value to archive 50% PoV consumption we could try a proof limit of 1.31 since 50/(19/50) = 131%.

Changes:

• 🚨 Change pallet_glutton::{set_compute, set_storage} args from Perbill to FixedU64
• 🚨 Same for GenesisConfig
• Fix re-export of FixedU64 in sp-runtime and sp-arithmetic
• Some pallet code cleanup.

👉 Pallet glutton is not (and never will be) advised for deployment on value-bearing chains. Note that there is no storage migration provided. Test chains using this need to be re-genesised.
Cumulus companion: paritytech/cumulus#2730

@NachoPal @Szegoo please let me know if you see something amiss.

[Szegoo]

The changes seem good to me. The only question I have may be a bit off-topic.
Wouldn't it be a good idea if we had per_thing implementations that are not limited to 100%? If we had that we wouldn't have to use FixedU64 in situations like this.

[ggwpez]

The changes seem good to me. The only question I have may be a bit off-topic.
Wouldn't it be a good idea if we had per_thing implementations that are not limited to 100%? If we had that we wouldn't have to use FixedU64 in situations like this.

The whole reason to have per_thing is to be in range [0, 1] with maximum precision. We just need this very often to express ratios.
If we enlarge the range, then it will be the same as FixedU*. There is nothing wrong with using FixedU64 here AFAIK, it has the same encoded size and should still be sufficiently precise in the range [0, 10].

[NachoPal]

@ggwpez Where did you see it is consuming only 19% of the proof_size?

[sandreim]

@ggwpez Where did you see it is consuming only 19% of the proof_size?

https://grafana.parity-mgmt.parity.io/goto/tJ1Pf9l4g?orgId=1

2023-06-13 07:59:00.543  INFO tokio-runtime-worker cumulus-collator: [Parachain] PoV size { header: 0.1396484375kb, extrinsics: 3.22265625kb, storage_proof: 980.1328125kb } 

[ggwpez]

bot bench $ pallet dev pallet-glutton

[command-bot]

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2978867 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-glutton. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-a1a7a114-3e34-491b-9c92-ed0c9bf8efd2 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-glutton has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2978867 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2978867/artifacts/download.

[ggwpez]

bot bench $ pallet dev pallet-glutton

[command-bot]

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2979580 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-glutton. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-86b3b6e3-b33c-4ed4-a418-0cddc89f0da0 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-glutton has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2979580 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2979580/artifacts/download.

[ggwpez]

bot merge