Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

suppress unused warning in kitchensink example #14417

Merged
merged 5 commits into from
Jun 21, 2023
Merged

suppress unused warning in kitchensink example #14417

merged 5 commits into from
Jun 21, 2023

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Jun 19, 2023 •
edited
Loading

This fixes the unused error for new_test_ext() in the kitchensink example when running cargo test with no arguments

Happy to address this some other way like with a cfg flag if appropriate.

Fixes the unused error for new_test_ext() when compiling cargo test by adding a test that uses it

@sam0x17 sam0x17 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 19, 2023
@sam0x17 sam0x17 self-assigned this Jun 19, 2023
@sam0x17 sam0x17 requested review from a team June 19, 2023 14:37
@sam0x17
Copy link
Contributor Author

sam0x17 commented Jun 19, 2023

This also raises the question: do we not check that cargo test with no arguments has no warnings in CI?

@paritytech-ci paritytech-ci requested a review from a team June 19, 2023 18:47
@gupnik
Copy link
Contributor

gupnik commented Jun 21, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 21, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-ff4704ef-090b-4811-a343-3e7127216169 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 21, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3045422/artifacts/download.

@sam0x17 sam0x17 requested a review from a team June 21, 2023 16:31
@bkchr bkchr merged commit e72781c into master Jun 21, 2023
@bkchr bkchr deleted the sam-fix-test-warnings branch June 21, 2023 22:13
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@sam0x17 @gupnik @nathanwhit
suppress unused warning in kitchensink example (paritytech#14417)
2fc7218 
* suppress unused warning in kitchensink example

* Adds test

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com>
Co-authored-by: command-bot <>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez left review comments

@gupnik gupnik gupnik approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees

@sam0x17 sam0x17

@gupnik gupnik

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam0x17 @gupnik @kianenigma @bkchr @ggwpez