Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pallets: Assets destroy_accounts releases the deposit #14443

Merged
merged 5 commits into from
Jul 1, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Jun 22, 2023

Destroy accounts should release the existence deposits if any.

Currently, when accounts are being destroyed, deposits are not released. The dead_account function is executed forcefully, allowing the removal of the asset even if some accounts were not removed correctly.
In the PR we release the deposits on the account destroy and do not force the dead_account function.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 22, 2023
@muharem muharem requested review from a team June 22, 2023 15:21
@muharem muharem removed the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jun 22, 2023
gavofyork and others added 2 commits June 25, 2023 13:35
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 26, 2023
@muharem
Copy link
Contributor Author

muharem commented Jul 1, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@muharem
Copy link
Contributor Author

muharem commented Jul 1, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from 879ddb9 to 702abcf

@muharem
Copy link
Contributor Author

muharem commented Jul 1, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 433bc24 into master Jul 1, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-assets-unreserve-deposit branch July 1, 2023 15:48
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…4443)

* assset accounts destroy releases the deposit

* enumerate

* Update frame/assets/src/functions.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* import defensive from frame_support

---------

Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants