Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Run integrity_test in Externalities #14546

Merged
merged 14 commits into from
Jul 18, 2023
Merged

Run integrity_test in Externalities #14546

merged 14 commits into from
Jul 18, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jul 11, 2023 •
edited
Loading

Closes #13726

Changes:

  • Always run integrity_test in test externalities.

ggwpez added 4 commits July 11, 2023 13:16
@ggwpez
Run integrity_test in RO externalities
ee5d140 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
frame-support: Export RO externalities
136cb6b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix bench tests
5487bdb 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update docs
b3e322b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from a team July 11, 2023 11:18
@ggwpez ggwpez changed the title Oty integrity ext Run integrity_test in RO Externalities Jul 11, 2023
@ggwpez ggwpez self-assigned this Jul 11, 2023
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. B1-note_worthy Changes should be noted in the release notes and removed B0-silent Changes should not be mentioned in any release notes labels Jul 11, 2023
bkchr
bkchr reviewed Jul 11, 2023
View reviewed changes
frame/support/src/lib.rs Outdated Show resolved Hide resolved
frame/support/procedural/src/pallet/expand/hooks.rs Outdated Show resolved Hide resolved
frame/system/benchmarking/src/lib.rs
@@ -18,6 +18,7 @@
// Benchmarks for Utility Pallet

#![cfg_attr(not(feature = "std"), no_std)]
#![cfg(feature = "runtime-benchmarks")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the pallet even has this feature as this pallet should only be used when runtime-benchmarks are enabled somewhere else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just running the tests for all pallets and one of the benchmarking tests failed. So it was "enabled" manually by cargo test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, my build isn't working. can we have this ported to the 1.0.0 release branch @bkchr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the correct solution #14617

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0 release branch is for the node - not the runtime. There is no 1.0.0 runtime release yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this for Acala to compile with polkadot-v1.0.0 branch

ggwpez added 4 commits July 11, 2023 14:14
@ggwpez
Rename to __private
30d3a19 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Run in TestExternalities
552a0dd 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix other pallets
a8cc2af 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update docs
5ba88f2 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team July 11, 2023 14:38
@ggwpez ggwpez changed the title Run integrity_test in RO Externalities Run integrity_test in Externalities Jul 11, 2023
@ggwpez
Fixes
8d93eef 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jul 12, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

muharem
muharem approved these changes Jul 14, 2023
View reviewed changes
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
ggwpez and others added 2 commits July 17, 2023 23:04
@ggwpez @muharem
Update frame/support/src/dispatch.rs
d7a1bc0 
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-integrity-ext
9f32ff3 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fixup merge
8371c01 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jul 17, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 8371c01

@ggwpez
Copy link
Member Author

ggwpez commented Jul 18, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@ggwpez
Copy link
Member Author

ggwpez commented Jul 18, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit d6b45e5 into master Jul 18, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-integrity-ext branch July 18, 2023 10:10
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @muharem @nathanwhit
Run integrity_test in Externalities (paritytech#14546)
cdcd4c4 
* Run integrity_test in RO externalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* frame-support: Export RO externalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix bench tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename to __private

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Run in TestExternalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix other pallets

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/support/src/dispatch.rs

Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>

* Fixup merge

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
@ggwpez @muharem @Ank4n
Run integrity_test in Externalities (#14546)
3eeafc8 
* Run integrity_test in RO externalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* frame-support: Export RO externalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix bench tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename to __private

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Run in TestExternalities

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix other pallets

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/support/src/dispatch.rs

Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>

* Fixup merge

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xlc xlc xlc left review comments

@muharem muharem muharem approved these changes

@bkchr bkchr bkchr approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run integrity_test in externalities
4 participants
@ggwpez @xlc @bkchr @muharem