Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[contracts] Derive useful traits for public types #14723

Conversation

pmikolajczyk41
Copy link
Contributor

Description

We add a few derivations to the public types from pallet-contracts and pallet-contracts-primitives crates. While they are not used directly in the runtime (and thus the implementation code will be pruned by a compiler), they would be very useful for contracts-related tooling. Also, this brings a bit more consistency to these libraries' public API (e.g. schedule module has already all its public types enriched with many similar trait derivations).

Checklist

  • My PR includes a detailed description as outlined in the "Description" section above
  • My PR follows the labeling requirements of this project (at minimum one label for each A, B, C and D required)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • If this PR alters any external APIs or interfaces used by Polkadot, the corresponding Polkadot PR is ready as well as the corresponding Cumulus PR (optional)

@pmikolajczyk41 pmikolajczyk41 requested a review from athei as a code owner August 7, 2023 09:07
@pmikolajczyk41 pmikolajczyk41 requested a review from a team August 7, 2023 09:07
@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 8, 2023
@ascjones
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ca379d7 into paritytech:master Aug 14, 2023
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk41/derives branch August 14, 2023 09:32
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants