Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update primitive types minor version and solve breaking changes #1535

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jan 23, 2019

primitive types doesn't implement From for H256 and else. So this make the conversion explicit in our test by using from_low_u64_be

only test are affected.

@gui1117 gui1117 requested a review from bkchr January 23, 2019 15:48
@rphmeier rphmeier added A0-please_review Pull request needs code review. B2-breaksapi labels Jan 23, 2019
@bkchr bkchr merged commit 9040ca9 into master Jan 23, 2019
@bkchr bkchr deleted the gui-update-primitive-types branch January 23, 2019 17:26
bkchr pushed a commit to tomaka/polkadot that referenced this pull request Feb 7, 2019
arkpar pushed a commit that referenced this pull request Feb 7, 2019
* Protect against flood of addresses

* Fix CI issue

* update primitive-types and solve break changes (#1535)
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants